ref: Use a Context type mapping to map[string]interface{} #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phacops
force-pushed
the
pierre/context-as-map-string-interface
branch
from
49650f9
to
f555dc7
Compare
kamilogorek
suggested changes
May 27, 2022
.pre-commit-config.yaml
Outdated
| - id: go-fmt | ||
| - id: go-imports | ||
| - id: golangci-lint | ||
| - id: no-go-testing |
There was a problem hiding this comment.
Can you move this to a separate PR?
interfaces.go
Outdated
| @@ -161,10 +161,12 @@ type Exception struct { | |||
| // An EventID must be 32 characters long, lowercase and not have any dashes. | |||
| type EventID string | |||
|
|
|||
| type Context map[string]interface{} | |||
There was a problem hiding this comment.
I'm not sure if we should introduce a concrete Context type. It'll force people to pass sentry.Context explicitly. Where if we'd use type alias, type Context = map[string]interface{}, it'd still work with most cases where people already pass a valid dictionary.
There was a problem hiding this comment.
I defined a new type since you mention on Slack it was a v0 and we should strive to make the API as it should. The type alias works too and the difference is minimal so that'll works well too.
Co-authored-by: Kamil Ogórek <kamil@sentry.io>
kamilogorek
approved these changes
May 31, 2022
This was referenced Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Sentry processes an event, it only accepts a context being a key/value object. This PR aims to enforce we're passing a
map[string]interface{}instead of aninterface{}.