build: Bump Go version in go.mod #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dashed you're so fast :-) |
Commit generated with this command go mod tidy -go=1.17 -compat=1.15 Using Go version 1.17.5. The idea is to enable consumers of sentry-go to be able to use module graph pruning (Go 1.17+ required), such that dependencies of sentry-go that are otherwise unused by end users can be pruned away. See getsentry#156 (comment) Also update CI workflow to check for go.mod tidiness using the same line as used to generate this commit. Update data race tests that were still accidentally being run on Go 1.16 instead of 1.17.
rhcarvalho
force-pushed
the
gomod-1.17
branch
from
6c004c5
to
78f200c
Compare
|
The CodeQL failure can likely be ignored. It should have been addressed by github/codeql-go#658 (which closed github/codeql-go#650). @kamilogorek do you know who's taking a look here these days? |
At last 😌
Noone just yet 😔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit generated with this command
Using Go version 1.17.5.
The idea is to enable consumers of sentry-go to be able to use module
graph pruning (Go 1.17+ required), such that dependencies of sentry-go
that are otherwise unused by end users can be pruned away.
See #156 (comment)
Also update CI workflow to check for go.mod tidiness using the same line
as used to generate this commit. Update data race tests that were still
accidentally being run on Go 1.16 instead of 1.17.