fix: When extracting PCs from stack frames, try the PC field
#393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some error types may return stack traces already defined as `[]runtime.Frame`. In this case, the program counter will be in the `PC` field. fixes: getsentry#391
kamilogorek
approved these changes
Feb 25, 2022
|
Thanks! The change looks trivial, so there should be no issues getting it out there, especially that iteration order preserves |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some error types may return stack traces already defined as
[]runtime.Frame.In this case, the program counter will be in the
PCfield.fixes: #391