Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto Instrumentation for Performance Monitoring #390

Open
odannyc opened this issue Nov 2, 2021 · 2 comments
Open

Auto Instrumentation for Performance Monitoring #390

odannyc opened this issue Nov 2, 2021 · 2 comments

Comments

@odannyc
Copy link

odannyc commented Nov 2, 2021

Summary

I'd like for sentry-go to provide ways to auto-instrument multiple common integrations. The most common ones are database/sql, pq, http...

Motivation

New Relic, DataDog and other packages that provide tracing already have these helper methods of instrumenting your application. Here is just one example of New Relic giving you ways to instrument the pq library: https://github.com/newrelic/go-agent/blob/master/v3/integrations/nrpq/README.md

Here are all the instrumentation helpers that datadog gives you:

https://github.com/DataDog/dd-trace-go/tree/v1/contrib

@aldy505
Copy link
Contributor

aldy505 commented Apr 3, 2024

@cleptric Is this still on track? I have my own implementation for some things that I often use here https://github.com/aldy505/sentry-integration, most users probably will use the pgx and http.Client one. But I don't know if this approach aligns with tracing with otel.

@cleptric
Copy link
Member

cleptric commented Apr 3, 2024

http.Client would be a good candidate, but we must first ship Tracing without Performance. With the new APIs added here, we can always attach a sentry-trace and baggage header, regardless of performance being enabled or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

4 participants