Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentry.Config.dsn/0 is not a string #730

Closed
maennchen opened this issue May 5, 2024 · 1 comment · Fixed by #731
Closed

Sentry.Config.dsn/0 is not a string #730

maennchen opened this issue May 5, 2024 · 1 comment · Fixed by #731
Assignees

Comments

@maennchen
Copy link

maennchen commented May 5, 2024

Environment

10.5.0

Steps to Reproduce

The integration was originally added with major version 8 and worked great. After the update to version 10, the dsn is no longer a string.

Back in version 8, the module Sentry.Config was public. Now it is marked with @moduledoc false.

Expected Result

Works and only uses public APIs.

Alternatively, the docs should provide an alternative to achieve the same result.

Actual Result

14:32:56.317 [error] #PID<0.708.0> running Phoenix.Endpoint.SyncCodeReloadPlug (connection #PID<0.707.0>, stream id 1) terminated
Server: localhost:4000 (http)
Request: GET /url
** (exit) an exception was raised:
    ** (Protocol.UndefinedError) protocol Phoenix.HTML.Safe not implemented for {"https://[...].ingest.us.sentry.io/api/[...]/envelope/", "[...]", nil} of type Tuple. This protocol is implemented for the following type(s): Atom, BitString, Date, DateTime, Decimal, Float, Integer, List, NaiveDateTime, Phoenix.LiveComponent.CID, Phoenix.LiveView.Component, Phoenix.LiveView.Comprehension, Phoenix.LiveView.JS, Phoenix.LiveView.Rendered, Time, Tuple, URI
        (phoenix_html 4.1.1) lib/phoenix_html/safe.ex:97: Phoenix.HTML.Safe.Tuple.to_iodata/1
        (phoenix_html 4.1.1) lib/phoenix_html.ex:238: Phoenix.HTML.build_attrs/1
        (phoenix_html 4.1.1) lib/phoenix_html.ex:191: Phoenix.HTML.attributes_escape/1
        (acme 1.0.0) lib/acme_web/components/layouts/root.html.heex:2: anonymous fn/2 in AcmeWeb.Layouts.root/1

Using API marked as @moduledoc false.

@whatyouhide whatyouhide self-assigned this May 5, 2024
@whatyouhide whatyouhide changed the title Sentry.Config.dsn/0 is not a string. Sentry.Config.dsn/0 is not a string May 10, 2024
whatyouhide added a commit to whatyouhide/sentry-docs that referenced this issue May 11, 2024
@whatyouhide
Copy link
Collaborator

whatyouhide commented May 11, 2024

Good catch. Will be released in the next minor version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants