ref: diagnosticLevel #759
Merged
ref: diagnosticLevel #759
+26
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
reviewed
Jan 23, 2021
| @@ -326,7 +326,7 @@ public bool Debug | |||
| /// <remarks> | |||
| /// The <see cref="Debug"/> flag has to be switched on for this setting to take effect. | |||
| /// </remarks> | |||
| public SentryLevel DiagnosticsLevel { get; set; } = SentryLevel.Debug; | |||
| public SentryLevel DiagnosticLevel { get; set; } = SentryLevel.Debug; | |||
There was a problem hiding this comment.
M: why don't we deprecate DiagnosticsLevel and forwards getters/setters to DiagnosticLevel? so we won't break people's code, we could remove on the next version
There was a problem hiding this comment.
It's a major bump and a niche option (most ppl are not fiddling with this).
Since it's a major bump and it's an easy to discover fix (even looking at intellisense ppl can figure out) I rather we just do it (optimize for our maintainalibiliy in this case).
If this was a rename on BeforeSend for example I'd surely not do this same thing.
marandaneto
approved these changes
Jan 23, 2021
Tyrrrz
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To align with Dart and Java:
getsentry/sentry-docs#2945