Skip to content

Adds to the existing User Other dict rather than replacing #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

brettjenkins
Copy link
Contributor

@event.User.Other will never be null here, so haven't put in a null ref check as was suggested in the issue

@event.User.Other will never be null here, so haven't put in a null ref check as was suggested in the issue
@brettjenkins brettjenkins changed the title Adds to the existing Other dict rather than replacing (#718) Adds to the existing User Other dict rather than replacing (#718) Jan 7, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @brettjenkins !

@bruno-garcia bruno-garcia enabled auto-merge (squash) January 8, 2021 01:41
@bruno-garcia bruno-garcia disabled auto-merge January 8, 2021 01:41
@bruno-garcia bruno-garcia enabled auto-merge (squash) January 8, 2021 01:41
@bruno-garcia bruno-garcia changed the title Adds to the existing User Other dict rather than replacing (#718) Adds to the existing User Other dict rather than replacing Jan 8, 2021
@bruno-garcia bruno-garcia disabled auto-merge January 8, 2021 01:48

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…s-true-718
@bruno-garcia bruno-garcia merged commit ed48af8 into getsentry:main Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants