Add NRTS to Sentry.Extensions.Logging #524
Merged
+68
−109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyrrrz
commented
Sep 23, 2020
Codecov Report
@@ Coverage Diff @@
## main #524 +/- ##
==========================================
+ Coverage 60.10% 60.37% +0.26%
==========================================
Files 112 112
Lines 2642 2660 +18
Branches 599 601 +2
==========================================
+ Hits 1588 1606 +18
- Misses 871 872 +1
+ Partials 183 182 -1
Continue to review full report at Codecov.
|
bruno-garcia
approved these changes
Sep 23, 2020
| @@ -7,6 +7,12 @@ | |||
| <AssemblyName>Sentry.Extensions.Logging</AssemblyName> | |||
| <RootNamespace>Sentry.Extensions.Logging</RootNamespace> | |||
| <Description>Official Microsoft.Extensions.Logging integration for Sentry - Open-source error tracking that helps developers monitor and fix crashes in real time.</Description> | |||
| <Nullable>enable</Nullable> | |||
There was a problem hiding this comment.
If this is the last package, can we move this to the root Directory.Build.props?
Or actually just the src
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.