-
-
Notifications
You must be signed in to change notification settings - Fork 220
Add logger and category from Serilog SourceContext. #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logger and category from Serilog SourceContext. #316
Conversation
Codecov Report
@@ Coverage Diff @@
## master #316 +/- ##
========================================
Coverage ? 92.1%
========================================
Files ? 82
Lines ? 2115
Branches ? 0
========================================
Hits ? 1948
Misses ? 167
Partials ? 0
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your addition.
Could you please add some tests to verify the behavior?
Sure, I'll in the weekend. |
Thanks for you PR and sorry for the delay. |
Co-Authored-By: Bruno Garcia <bruno@brunogarcia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll fix the build and add the test later.
Tks
Actually I just noticed you commited the suggestion but it involved getting rid of the Could you please fix that so it compiles? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please delete logger
and use context
so it compiles
Thanks! |
Logger and category (breadcrumbs) are lost when using Serilog extension. This PR adds support for them to store into the event and breadcrumbs.