Skip to content

ref: Don't use ValueTuple #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2019
Merged

ref: Don't use ValueTuple #263

merged 1 commit into from
Sep 2, 2019

Conversation

bruno-garcia
Copy link
Member

@bruno-garcia bruno-garcia commented Aug 17, 2019

Required for: #256

@codecov-io
Copy link

codecov-io commented Aug 17, 2019

Codecov Report

Merging #263 into master will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #263     +/-   ##
=========================================
+ Coverage   91.58%   91.68%   +0.1%     
=========================================
  Files          81       81             
  Lines        2044     2045      +1     
=========================================
+ Hits         1872     1875      +3     
+ Misses        172      170      -2
Impacted Files Coverage Δ
src/Sentry.NLog/SentryTarget.cs 94.3% <100%> (ø) ⬆️
src/Sentry/Internal/SentryScopeManager.cs 100% <100%> (ø) ⬆️
src/Sentry/Internal/MainSentryEventProcessor.cs 100% <100%> (ø) ⬆️
src/Sentry.AspNetCore/SentryMiddleware.cs 98.38% <100%> (ø) ⬆️
src/Sentry.Serilog/SentrySink.cs 84.21% <100%> (ø) ⬆️
src/Sentry/Reflection/AssemblyExtensions.cs 100% <100%> (ø) ⬆️
src/Sentry.Log4Net/SentryAppender.cs 94.93% <100%> (ø) ⬆️
.../Sentry.Extensions.Logging/SentryLoggerProvider.cs 100% <100%> (ø) ⬆️
src/Sentry/Internal/BackgroundWorker.cs 95.9% <0%> (+1.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5b0998...19aa0a4. Read the comment docs.

@bruno-garcia bruno-garcia merged commit c777366 into master Sep 2, 2019
@bruno-garcia bruno-garcia deleted the ref/dont-use-value-tuple branch September 2, 2019 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants