Skip to content

Ignore DioError deprecared member use #1510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 7, 2023

Conversation

marandaneto
Copy link
Contributor

📜 Description

#skip-changelog

💡 Motivation and Context

Relates to #1509

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Sorry, something went wrong.

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: +3.42 🎉

Comparison is base (4cf8625) 90.98% compared to head (65c177c) 94.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1510      +/-   ##
==========================================
+ Coverage   90.98%   94.40%   +3.42%     
==========================================
  Files          61        9      -52     
  Lines        2019      161    -1858     
==========================================
- Hits         1837      152    -1685     
+ Misses        182        9     -173     
Impacted Files Coverage Δ
dio/lib/src/dio_error_extractor.dart 100.00% <ø> (ø)
dio/lib/src/dio_event_processor.dart 97.14% <ø> (ø)
dio/lib/src/dio_stacktrace_extractor.dart 100.00% <ø> (ø)
dio/lib/src/failed_request_interceptor.dart 100.00% <ø> (ø)
dio/lib/src/sentry_dio_extension.dart 94.73% <ø> (ø)

... and 52 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 319.24 ms 389.84 ms 70.59 ms
Size 6.16 MiB 7.14 MiB 1003.22 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
eb1a7c1 332.98 ms 381.55 ms 48.57 ms
cdf7172 348.54 ms 390.81 ms 42.27 ms
870f5eb 329.45 ms 369.29 ms 39.84 ms
f96ca24 316.08 ms 388.22 ms 72.14 ms
f2db4ec 372.46 ms 469.72 ms 97.26 ms
134c9f8 301.40 ms 352.65 ms 51.26 ms
0db91cc 327.85 ms 387.31 ms 59.46 ms
b98109e 296.46 ms 362.68 ms 66.22 ms
519423f 357.00 ms 415.77 ms 58.77 ms
bf4aed7 311.24 ms 365.66 ms 54.42 ms

App size

Revision Plain With Sentry Diff
eb1a7c1 5.94 MiB 6.92 MiB 1005.76 KiB
cdf7172 5.94 MiB 6.95 MiB 1.01 MiB
870f5eb 5.94 MiB 6.92 MiB 1005.77 KiB
f96ca24 6.06 MiB 7.10 MiB 1.04 MiB
f2db4ec 6.06 MiB 7.03 MiB 990.27 KiB
134c9f8 5.94 MiB 6.95 MiB 1.01 MiB
0db91cc 5.94 MiB 6.95 MiB 1.01 MiB
b98109e 6.06 MiB 7.03 MiB 993.53 KiB
519423f 6.06 MiB 7.03 MiB 989.24 KiB
bf4aed7 6.06 MiB 7.03 MiB 997.04 KiB

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1244.96 ms 1269.18 ms 24.22 ms
Size 8.29 MiB 9.37 MiB 1.07 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
86d4841 1225.69 ms 1241.12 ms 15.43 ms
a2ec542 1258.33 ms 1267.20 ms 8.88 ms
8932ece 1234.31 ms 1238.90 ms 4.59 ms
6d317ea 1277.27 ms 1287.47 ms 10.20 ms
d61cecf 1276.96 ms 1290.02 ms 13.06 ms
68677de 1245.20 ms 1273.51 ms 28.31 ms
3637a22 1290.39 ms 1318.42 ms 28.03 ms
5aba417 1265.31 ms 1287.90 ms 22.59 ms
ad69abc 1259.00 ms 1261.60 ms 2.60 ms
dd1f7d2 1263.16 ms 1275.15 ms 11.99 ms

App size

Revision Plain With Sentry Diff
86d4841 8.29 MiB 9.36 MiB 1.07 MiB
a2ec542 8.10 MiB 9.14 MiB 1.05 MiB
8932ece 8.29 MiB 9.36 MiB 1.07 MiB
6d317ea 8.15 MiB 9.12 MiB 986.26 KiB
d61cecf 8.10 MiB 9.18 MiB 1.08 MiB
68677de 8.10 MiB 9.16 MiB 1.07 MiB
3637a22 8.09 MiB 9.07 MiB 1001.02 KiB
5aba417 8.16 MiB 9.17 MiB 1.01 MiB
ad69abc 8.10 MiB 9.08 MiB 1004.37 KiB
dd1f7d2 8.10 MiB 9.16 MiB 1.07 MiB

Copy link
Member

@stefanosiano stefanosiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but should we also provide support for DioException somehow?
Or would it mean to increase the minimum supported version of dio?

@marandaneto
Copy link
Contributor Author

This is fine, but should we also provide support for DioException somehow? Or would it mean to increase the minimum supported version of dio?

would it mean to increase the minimum supported version of dio

yes, so better to wait before the adoption of the new version is very relevant.

@marandaneto marandaneto merged commit c32fca3 into main Jun 7, 2023
@marandaneto marandaneto deleted the chore/ignore-deprecated-dio-error branch June 7, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants