Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sentry file to craft #1170

Merged
merged 4 commits into from Dec 9, 2022
Merged

Add sentry file to craft #1170

merged 4 commits into from Dec 9, 2022

Conversation

marandaneto
Copy link
Contributor

📜 Description

#skip-changelog

💡 Motivation and Context

getsentry/sentry-release-registry#97

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2022

Codecov Report

Base: 88.87% // Head: 88.87% // No change to project coverage 👍

Coverage data is based on head (4d0efee) compared to base (deaeece).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1170   +/-   ##
=======================================
  Coverage   88.87%   88.87%           
=======================================
  Files         121      121           
  Lines        3810     3810           
=======================================
  Hits         3386     3386           
  Misses        424      424           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@marandaneto marandaneto enabled auto-merge (squash) December 9, 2022 09:21
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2022

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 302.64 ms 348.98 ms 46.34 ms
Size 5.94 MiB 6.96 MiB 1.02 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
633cf2e 289.36 ms 340.38 ms 51.02 ms
f922f8f 332.31 ms 374.67 ms 42.37 ms
9f9f94f 331.04 ms 368.92 ms 37.88 ms
7ade5af 341.04 ms 386.84 ms 45.80 ms
6d7a391 331.94 ms 367.04 ms 35.10 ms
322aa66 284.98 ms 341.76 ms 56.78 ms
691aa3b 370.43 ms 466.28 ms 95.85 ms
af2d175 279.08 ms 312.37 ms 33.29 ms
9811573 309.76 ms 402.60 ms 92.84 ms
4efee31 308.92 ms 368.68 ms 59.76 ms

App size

Revision Plain With Sentry Diff
633cf2e 5.94 MiB 6.92 MiB 1001.53 KiB
f922f8f 5.94 MiB 6.95 MiB 1.01 MiB
9f9f94f 5.94 MiB 6.95 MiB 1.01 MiB
7ade5af 5.94 MiB 6.95 MiB 1.01 MiB
6d7a391 5.94 MiB 6.95 MiB 1.01 MiB
322aa66 5.94 MiB 6.92 MiB 1005.75 KiB
691aa3b 5.94 MiB 6.96 MiB 1.02 MiB
af2d175 5.94 MiB 6.92 MiB 1001.83 KiB
9811573 5.94 MiB 6.96 MiB 1.02 MiB
4efee31 5.94 MiB 6.92 MiB 1003.76 KiB

Previous results on branch: chore/craft-sentry-file

Startup times

Revision Plain With Sentry Diff
b3008dc 303.84 ms 341.16 ms 37.33 ms

App size

Revision Plain With Sentry Diff
b3008dc 5.94 MiB 6.96 MiB 1.02 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2022

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1297.73 ms 1303.53 ms 5.80 ms
Size 8.16 MiB 9.17 MiB 1.01 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
ef2f368 1259.12 ms 1277.04 ms 17.92 ms
a7acb24 1296.71 ms 1317.69 ms 20.98 ms
af2d175 1280.37 ms 1282.24 ms 1.88 ms
25e9b59 1289.76 ms 1295.27 ms 5.51 ms
0db91cc 1267.63 ms 1279.69 ms 12.06 ms
5aba417 1265.31 ms 1287.90 ms 22.59 ms
691aa3b 1265.57 ms 1282.13 ms 16.55 ms
322aa66 1251.68 ms 1275.52 ms 23.84 ms
9f9f94f 1268.33 ms 1284.73 ms 16.41 ms
613760b 1263.10 ms 1277.27 ms 14.16 ms

App size

Revision Plain With Sentry Diff
ef2f368 8.15 MiB 9.10 MiB 965.24 KiB
a7acb24 8.16 MiB 9.17 MiB 1.01 MiB
af2d175 8.15 MiB 9.12 MiB 986.22 KiB
25e9b59 8.16 MiB 9.15 MiB 1021.15 KiB
0db91cc 8.15 MiB 9.15 MiB 1018.56 KiB
5aba417 8.16 MiB 9.17 MiB 1.01 MiB
691aa3b 8.16 MiB 9.17 MiB 1.01 MiB
322aa66 8.15 MiB 9.12 MiB 992.53 KiB
9f9f94f 8.15 MiB 9.15 MiB 1020.76 KiB
613760b 8.15 MiB 9.13 MiB 1000.46 KiB

Previous results on branch: chore/craft-sentry-file

Startup times

Revision Plain With Sentry Diff
b3008dc 1251.96 ms 1262.63 ms 10.67 ms

App size

Revision Plain With Sentry Diff
b3008dc 8.16 MiB 9.17 MiB 1.01 MiB

@marandaneto marandaneto merged commit d235a79 into main Dec 9, 2022
@marandaneto marandaneto deleted the chore/craft-sentry-file branch December 9, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants