New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable strict mode for all SDKs but dart #1163
Conversation
Android Performance metrics ๐
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
b728df4 | 390.98 ms | 445.81 ms | 54.83 ms |
56810ff | 309.72 ms | 352.26 ms | 42.54 ms |
5603ab2 | 309.84 ms | 345.20 ms | 35.36 ms |
7ade5af | 341.04 ms | 386.84 ms | 45.80 ms |
453e1bc | 320.41 ms | 372.73 ms | 52.32 ms |
0ceb89c | 304.57 ms | 357.18 ms | 52.61 ms |
af2d175 | 279.08 ms | 312.37 ms | 33.29 ms |
aa950e9 | 337.42 ms | 400.72 ms | 63.30 ms |
72dfc83 | 298.62 ms | 340.14 ms | 41.52 ms |
48e79fd | 354.22 ms | 391.46 ms | 37.24 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
b728df4 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
56810ff | 5.94 MiB | 6.92 MiB | 1001.71 KiB |
5603ab2 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
7ade5af | 5.94 MiB | 6.95 MiB | 1.01 MiB |
453e1bc | 5.94 MiB | 6.95 MiB | 1.01 MiB |
0ceb89c | 5.94 MiB | 6.95 MiB | 1.01 MiB |
af2d175 | 5.94 MiB | 6.92 MiB | 1001.83 KiB |
aa950e9 | 5.94 MiB | 6.96 MiB | 1.02 MiB |
72dfc83 | 5.94 MiB | 6.92 MiB | 1001.71 KiB |
48e79fd | 5.94 MiB | 6.95 MiB | 1.01 MiB |
iOS Performance metrics ๐
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
ae02632 | 1286.77 ms | 1300.37 ms | 13.60 ms |
21845e2 | 1279.37 ms | 1298.81 ms | 19.45 ms |
f922f8f | 1249.53 ms | 1266.51 ms | 16.98 ms |
aa950e9 | 1275.17 ms | 1295.33 ms | 20.16 ms |
f4cc744 | 1274.57 ms | 1290.79 ms | 16.22 ms |
613760b | 1263.10 ms | 1277.27 ms | 14.16 ms |
6325c3b | 1266.52 ms | 1291.06 ms | 24.54 ms |
9f9f94f | 1268.33 ms | 1284.73 ms | 16.41 ms |
04db237 | 1273.29 ms | 1306.50 ms | 33.21 ms |
af2d175 | 1280.37 ms | 1282.24 ms | 1.88 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
ae02632 | 8.16 MiB | 9.15 MiB | 1020.68 KiB |
21845e2 | 8.15 MiB | 9.12 MiB | 991.34 KiB |
f922f8f | 8.15 MiB | 9.13 MiB | 1003.20 KiB |
aa950e9 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
f4cc744 | 8.16 MiB | 9.16 MiB | 1.01 MiB |
613760b | 8.15 MiB | 9.13 MiB | 1000.46 KiB |
6325c3b | 8.16 MiB | 9.17 MiB | 1.01 MiB |
9f9f94f | 8.15 MiB | 9.15 MiB | 1020.76 KiB |
04db237 | 8.15 MiB | 9.13 MiB | 1003.16 KiB |
af2d175 | 8.15 MiB | 9.12 MiB | 986.22 KiB |
Codecov ReportBase: 90.03% // Head: 90.14% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1163 +/- ##
==========================================
+ Coverage 90.03% 90.14% +0.10%
==========================================
Files 110 119 +9
Lines 3483 3672 +189
==========================================
+ Hits 3136 3310 +174
- Misses 347 362 +15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. โ View full report at Codecov. |
๐ Description
#skip-changelog
๐ก Motivation and Context
https://dart.dev/guides/language/analysis-options#enabling-additional-type-checks
๐ How did you test it?
๐ Checklist
๐ฎ Next steps
dart
package but that would be another PR since its much bigger and more fragile