New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Without dist
explicitly set it shows on Android but not on iOS
#280
Comments
Hey all, slight confusion here on my part. Sorry @bruno-garcia for the misleading Slack message. The script tag seems to be working as expected, but one thing I noticed was that the
This is only happening on Android, not iOs. Any advice for how to work around this? |
dist
explicitly set it shows on Android but no on iOSdist
explicitly set it shows on Android but not on iOS
Just to be clear, the issue here is the |
@lucas-zimerman yes that's the concern. The workaround is to manually remove it from events but this customer would rather it not get set at all if they don't declare it. To my knowledge, this is how sentry-react-native handles this but I might be mistaken. |
By the way, do you have a sample that you are testing Cordova? I was going to check what's going on but I found another issue that is not allowing me to validate it on my sample app 😅 |
I don't have a sample app to test this, unfortunately. I'm going to move forward with recommending they remove the field in beforeSend as a temporary workaround. |
@souredoutlook Ok so, I was able to reproduce it and we could do two things:
I believe the second option is more adequate since it'll not generate any break changes if users are using the default dist. |
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
I'll defer to @kahest as I dunno how to proceed |
Thanks for investigating this @lucas-zimerman! |
Implementing this solution getsentry/sentry-capacitor#480 will fix this issue |
e.g:
The text was updated successfully, but these errors were encountered: