Skip to content

feat: Add maxAttachmentSize to SentryOptions #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 28, 2020

Conversation

philipphofmann
Copy link
Member

📜 Description

Drop attachments that are larger than the specified maxAttachmentSize in SentryOptions.

💡 Motivation and Context

We want to give the users of the SDK the possibility to drop large attachments.

💚 How did you test it?

Unit tests.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the CHANGELOG
  • I updated the docs if needed
  • Review from the native team if needed
  • No breaking changes

🔮 Next steps

Sorry, something went wrong.

Drop attachments that are larger than the specified maxAttachmentSize in SentryOptions.
@philipphofmann philipphofmann added this to the 6.1.0 milestone Dec 23, 2020
@philipphofmann philipphofmann requested a review from a team December 23, 2020 10:37
@philipphofmann philipphofmann self-assigned this Dec 23, 2020
@codecov-io
Copy link

codecov-io commented Dec 23, 2020

Codecov Report

Merging #887 (5334690) into master (2d525f4) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #887      +/-   ##
==========================================
- Coverage   94.37%   94.37%   -0.01%     
==========================================
  Files          75       75              
  Lines        3360     3394      +34     
==========================================
+ Hits         3171     3203      +32     
- Misses        189      191       +2     
Impacted Files Coverage Δ
Sources/Sentry/SentryEnvelope.m 92.46% <100.00%> (+0.15%) ⬆️
Sources/Sentry/SentryHttpTransport.m 95.45% <100.00%> (+0.10%) ⬆️
Sources/Sentry/SentryOptions.m 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d525f4...5334690. Read the comment docs.

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm but I think 5 mb is too small.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants