feat: Add storeEnvelope on SentryClient #836
Merged
+26
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hybrid SDKs as react-native need a way to synchronously store an envelope to disk. Previously, this was possible by exposing SentryFileManager on the SentryClient, but this breaks users of react-native that use use_frameworks!, see getsentry/sentry-react-native#1171. A way to fix this would be to expose SentryFileManager and SentryCurrentDateProvider as proposed in #835. This has the downside of making classes public, that shouldn't be public. A better workaround is to expose storeEnvelope on the SentryClient.
5 tasks
Codecov Report
@@ Coverage Diff @@
## master #836 +/- ##
==========================================
- Coverage 83.49% 83.47% -0.03%
==========================================
Files 237 237
Lines 18482 18488 +6
==========================================
+ Hits 15432 15433 +1
- Misses 3050 3055 +5
Continue to review full report at Codecov.
|
|
Still waiting for feedback from @jennmueng, if this works for react-native. |
jennmueng
approved these changes
Nov 10, 2020
There was a problem hiding this comment.
@philipphofmann Confirmed that it works on React Native with use_frameworks! in the Podfile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Hybrid SDKs as react-native need a way to synchronously store an envelope to disk. Previously, this
was possible by exposing SentryFileManager on the SentryClient, but this breaks users of
react-native that use use_frameworks!,
see getsentry/sentry-react-native#1171. A way to fix this would be to expose
SentryFileManager and SentryCurrentDateProvider as proposed in
#835. This has the downside of making classes public,
that shouldn't be public. A better workaround is to expose storeEnvelope on the SentryClient.
💡 Motivation and Context
See #835.
💚 How did you test it?
Unit tests and CI.
📝 Checklist
🔮 Next steps