-
-
Notifications
You must be signed in to change notification settings - Fork 352
fix: Detect AppHangsV2 when tracing not enabled #5184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
AppHangsV2 didn't detect any app hangs when tracing was disabled. This is fixed now.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5184 +/- ##
=============================================
+ Coverage 92.731% 92.747% +0.016%
=============================================
Files 677 677
Lines 84586 84665 +79
Branches 30766 30802 +36
=============================================
+ Hits 78438 78525 +87
+ Misses 6045 6038 -7
+ Partials 103 102 -1
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
a5c946b | 1219.33 ms | 1236.53 ms | 17.20 ms |
b2fea10 | 1231.43 ms | 1238.63 ms | 7.20 ms |
feba2be | 1246.67 ms | 1254.64 ms | 7.97 ms |
32ac934 | 1230.13 ms | 1255.43 ms | 25.30 ms |
2f9c5f9 | 1218.78 ms | 1239.58 ms | 20.80 ms |
98a8c16 | 1234.69 ms | 1265.02 ms | 30.33 ms |
4f31f66 | 1213.96 ms | 1236.76 ms | 22.80 ms |
ef25af3 | 1237.88 ms | 1252.22 ms | 14.34 ms |
dc0db9e | 1246.06 ms | 1260.46 ms | 14.40 ms |
bdd896e | 1211.19 ms | 1239.06 ms | 27.87 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
a5c946b | 20.76 KiB | 431.93 KiB | 411.17 KiB |
b2fea10 | 21.58 KiB | 683.79 KiB | 662.21 KiB |
feba2be | 20.76 KiB | 414.45 KiB | 393.69 KiB |
32ac934 | 21.58 KiB | 616.72 KiB | 595.13 KiB |
2f9c5f9 | 21.58 KiB | 418.82 KiB | 397.24 KiB |
98a8c16 | 20.76 KiB | 431.00 KiB | 410.24 KiB |
4f31f66 | 21.58 KiB | 682.39 KiB | 660.81 KiB |
ef25af3 | 22.30 KiB | 845.77 KiB | 823.46 KiB |
dc0db9e | 20.76 KiB | 419.62 KiB | 398.86 KiB |
bdd896e | 22.31 KiB | 780.75 KiB | 758.43 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, little comment suggestion
Co-authored-by: Philip Niedertscheider <phil.niedertscheider@sentry.io>
📜 Description
AppHangsV2 didn't detect any app hangs when tracing was disabled. This is fixed now.
💡 Motivation and Context
Brought up in an internal Slack discussion.
💚 How did you test it?
Unit tests and simulator: sample event when having tracing disabled
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.