Skip to content

fix(profiling): start cancels prior stop request #4993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2025

Conversation

armcknight
Copy link
Member

After some discussion around how stop should work for the upcoming API changes, I realized this was incorrectly coded (or, correctly coded an incorrect assumption).

Stopping the continuous profiler doesn't immediately stop it, rather, it allows the current in-flight chunk to complete, then stops it. If a new call to start comes in, it should "cancel" the pending stop request, and simply allow the same continuous profiler to continue running.

Verified

This commit was signed with the committer’s verified signature.
armcknight Andrew McKnight

Verified

This commit was signed with the committer’s verified signature.
armcknight Andrew McKnight
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.706%. Comparing base (abff431) to head (7f6648d).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4993       +/-   ##
=============================================
- Coverage   92.707%   92.706%   -0.002%     
=============================================
  Files          672       672               
  Lines        82177     82205       +28     
  Branches     29839     29851       +12     
=============================================
+ Hits         76184     76209       +25     
- Misses        5897      5900        +3     
  Partials        96        96               
Files with missing lines Coverage Δ
...urces/Sentry/Profiling/SentryContinuousProfiler.mm 91.176% <100.000%> (ø)
...yProfilerTests/SentryContinuousProfilerTests.swift 97.971% <100.000%> (+0.172%) ⬆️

... and 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abff431...7f6648d. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@armcknight armcknight merged commit 05eeec2 into main Mar 18, 2025
69 of 75 checks passed
@armcknight armcknight deleted the armcknight/fix/continuous-profiling-stop branch March 18, 2025 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants