fix(profiling): start cancels prior stop request #4993
Merged
+36
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some discussion around how stop should work for the upcoming API changes, I realized this was incorrectly coded (or, correctly coded an incorrect assumption).
Stopping the continuous profiler doesn't immediately stop it, rather, it allows the current in-flight chunk to complete, then stops it. If a new call to start comes in, it should "cancel" the pending stop request, and simply allow the same continuous profiler to continue running.