-
-
Notifications
You must be signed in to change notification settings - Fork 352
impr: Avoid creating unnecessary UI transactions #4957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Skip creating user interaction transactions that would time out without any children. Fixes GH-2407
897eefb
to
ef24ac0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for removing the try!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4957 +/- ##
=============================================
+ Coverage 92.480% 92.496% +0.015%
=============================================
Files 666 666
Lines 78837 78844 +7
Branches 28532 28538 +6
=============================================
+ Hits 72909 72928 +19
+ Misses 5828 5817 -11
+ Partials 100 99 -1
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5b3518e | 1242.27 ms | 1257.81 ms | 15.55 ms |
a0cc9d6 | 1235.22 ms | 1248.37 ms | 13.14 ms |
556c407 | 1256.56 ms | 1274.60 ms | 18.04 ms |
98cca71 | 1199.08 ms | 1227.36 ms | 28.28 ms |
8cf5bca | 1231.33 ms | 1237.81 ms | 6.48 ms |
84fb4d9 | 1212.45 ms | 1223.39 ms | 10.94 ms |
d3630c3 | 1256.78 ms | 1274.10 ms | 17.32 ms |
de033da | 1206.55 ms | 1217.08 ms | 10.53 ms |
f278bab | 1236.50 ms | 1251.75 ms | 15.25 ms |
369222e | 1232.14 ms | 1258.90 ms | 26.76 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5b3518e | 21.58 KiB | 612.11 KiB | 590.53 KiB |
a0cc9d6 | 21.58 KiB | 706.47 KiB | 684.88 KiB |
556c407 | 22.85 KiB | 413.98 KiB | 391.13 KiB |
98cca71 | 22.85 KiB | 411.14 KiB | 388.29 KiB |
8cf5bca | 21.58 KiB | 671.30 KiB | 649.72 KiB |
84fb4d9 | 22.84 KiB | 402.56 KiB | 379.72 KiB |
d3630c3 | 22.84 KiB | 403.19 KiB | 380.34 KiB |
de033da | 21.58 KiB | 418.15 KiB | 396.57 KiB |
f278bab | 22.31 KiB | 760.65 KiB | 738.33 KiB |
369222e | 20.76 KiB | 419.67 KiB | 398.91 KiB |
Skip creating user interaction transactions that would time out without any children. Fixes GH-2407
Skip creating user interaction transactions that would time out without any children. Fixes GH-2407
📜 Description
Skip creating user interaction transactions that would time out without any children.
💡 Motivation and Context
Fixes GH-2407
💚 How did you test it?
Unit tests
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps