Skip to content

impr: Avoid creating unnecessary UI transactions #4957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 7, 2025

Conversation

philipphofmann
Copy link
Member

📜 Description

Skip creating user interaction transactions that would time out without any children.

💡 Motivation and Context

Fixes GH-2407

💚 How did you test it?

Unit tests

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
philipphofmann Philipp Hofmann
Skip creating user interaction transactions that would time out without
any children.

Fixes GH-2407

Verified

This commit was signed with the committer’s verified signature. The key has expired.
philipphofmann Philipp Hofmann
Copy link
Contributor

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for removing the try!

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.496%. Comparing base (b1ad543) to head (7f44a0b).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4957       +/-   ##
=============================================
+ Coverage   92.480%   92.496%   +0.015%     
=============================================
  Files          666       666               
  Lines        78837     78844        +7     
  Branches     28532     28538        +6     
=============================================
+ Hits         72909     72928       +19     
+ Misses        5828      5817       -11     
+ Partials       100        99        -1     
Files with missing lines Coverage Δ
...urces/Sentry/SentryUIEventTrackerTransactionMode.m 100.000% <100.000%> (ø)
...egrations/UIEvents/SentryUIEventTrackerTests.swift 99.612% <100.000%> (+0.012%) ⬆️

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1ad543...7f44a0b. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

github-actions bot commented Mar 7, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1225.41 ms 1247.98 ms 22.57 ms
Size 22.30 KiB 823.14 KiB 800.84 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5b3518e 1242.27 ms 1257.81 ms 15.55 ms
a0cc9d6 1235.22 ms 1248.37 ms 13.14 ms
556c407 1256.56 ms 1274.60 ms 18.04 ms
98cca71 1199.08 ms 1227.36 ms 28.28 ms
8cf5bca 1231.33 ms 1237.81 ms 6.48 ms
84fb4d9 1212.45 ms 1223.39 ms 10.94 ms
d3630c3 1256.78 ms 1274.10 ms 17.32 ms
de033da 1206.55 ms 1217.08 ms 10.53 ms
f278bab 1236.50 ms 1251.75 ms 15.25 ms
369222e 1232.14 ms 1258.90 ms 26.76 ms

App size

Revision Plain With Sentry Diff
5b3518e 21.58 KiB 612.11 KiB 590.53 KiB
a0cc9d6 21.58 KiB 706.47 KiB 684.88 KiB
556c407 22.85 KiB 413.98 KiB 391.13 KiB
98cca71 22.85 KiB 411.14 KiB 388.29 KiB
8cf5bca 21.58 KiB 671.30 KiB 649.72 KiB
84fb4d9 22.84 KiB 402.56 KiB 379.72 KiB
d3630c3 22.84 KiB 403.19 KiB 380.34 KiB
de033da 21.58 KiB 418.15 KiB 396.57 KiB
f278bab 22.31 KiB 760.65 KiB 738.33 KiB
369222e 20.76 KiB 419.67 KiB 398.91 KiB

@philipphofmann philipphofmann merged commit c48bcf6 into main Mar 7, 2025
70 of 72 checks passed
@philipphofmann philipphofmann deleted the impr/ui-transactions branch March 7, 2025 10:20
armcknight pushed a commit that referenced this pull request Mar 8, 2025

Verified

This commit was signed with the committer’s verified signature.
armcknight Andrew McKnight
Skip creating user interaction transactions that would time out without
any children.

Fixes GH-2407
armcknight pushed a commit that referenced this pull request Mar 8, 2025

Verified

This commit was signed with the committer’s verified signature.
armcknight Andrew McKnight
Skip creating user interaction transactions that would time out without
any children.

Fixes GH-2407
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not starting UI event transaction if transaction on Scope
2 participants