-
-
Notifications
You must be signed in to change notification settings - Fork 356
feat(feedback): initial release #4874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4874 +/- ##
=============================================
+ Coverage 92.251% 92.309% +0.057%
=============================================
Files 658 659 +1
Lines 77394 77560 +166
Branches 27938 28032 +94
=============================================
+ Hits 71397 71595 +198
+ Misses 5901 5865 -36
- Partials 96 100 +4
... and 34 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
f09e892 | 1220.22 ms | 1238.80 ms | 18.57 ms |
38ae188 | 1221.04 ms | 1246.91 ms | 25.87 ms |
cc14e49 | 1209.31 ms | 1231.54 ms | 22.24 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
f09e892 | 22.31 KiB | 820.98 KiB | 798.67 KiB |
38ae188 | 22.31 KiB | 820.94 KiB | 798.63 KiB |
cc14e49 | 22.31 KiB | 821.57 KiB | 799.26 KiB |
Previous results on branch: armcknight/feat(feedback)/initial-release
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
331f1be | 1197.30 ms | 1229.26 ms | 31.96 ms |
588c9d0 | 1243.65 ms | 1258.61 ms | 14.96 ms |
2b6f0d6 | 1221.55 ms | 1234.17 ms | 12.62 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
331f1be | 22.31 KiB | 821.88 KiB | 799.56 KiB |
588c9d0 | 22.31 KiB | 821.59 KiB | 799.28 KiB |
2b6f0d6 | 22.31 KiB | 821.70 KiB | 799.39 KiB |
4957680
to
e474fea
Compare
e474fea
to
5957494
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of comments, but other than that LGTM
Tests/SentryTests/Integrations/Feedback/SentryFeedbackTests.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with a couple of things to improve, but nothing blocking.
Publicly exposes the feature. For #4709
TODO: