Skip to content

feat(feedback): initial release #4874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Feb 25, 2025

Conversation

armcknight
Copy link
Member

@armcknight armcknight commented Feb 19, 2025

Publicly exposes the feature. For #4709

TODO:

Sorry, something went wrong.

@armcknight armcknight changed the base branch from main to armcknight/feat(feedback)/final-fixes February 19, 2025 23:37
Copy link
Contributor

github-actions bot commented Feb 19, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 5307575

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.309%. Comparing base (9798947) to head (5307575).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4874       +/-   ##
=============================================
+ Coverage   92.251%   92.309%   +0.057%     
=============================================
  Files          658       659        +1     
  Lines        77394     77560      +166     
  Branches     27938     28032       +94     
=============================================
+ Hits         71397     71595      +198     
+ Misses        5901      5865       -36     
- Partials        96       100        +4     
Files with missing lines Coverage Δ
SentryTestUtils/TestClient.swift 85.714% <100.000%> (+0.363%) ⬆️
SentryTestUtils/TestTransportAdapter.swift 84.210% <ø> (ø)
Sources/Sentry/SentryClient.m 98.309% <100.000%> (+3.125%) ⬆️
Sources/Sentry/SentryTransportAdapter.m 100.000% <ø> (ø)
Sources/Sentry/SentryUserFeedback.m 100.000% <ø> (ø)
...ift/Integrations/UserFeedback/SentryFeedback.swift 72.727% <100.000%> (ø)
...tryTests/Networking/SentryHttpTransportTests.swift 97.250% <100.000%> (+0.005%) ⬆️
...Tests/Networking/SentryTransportAdapterTests.swift 100.000% <ø> (ø)
...sts/SentryTests/Protocol/SentryEnvelopeTests.swift 96.024% <100.000%> (-0.049%) ⬇️
...SentryTests/Protocol/SentryUserFeedbackTests.swift 100.000% <ø> (ø)
... and 3 more

... and 34 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9798947...5307575. Read the comment docs.

Copy link
Contributor

github-actions bot commented Feb 19, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1227.55 ms 1244.76 ms 17.20 ms
Size 22.31 KiB 821.70 KiB 799.39 KiB

Baseline results on branch: armcknight/feat(feedback)/final-fixes

Startup times

Revision Plain With Sentry Diff
f09e892 1220.22 ms 1238.80 ms 18.57 ms
38ae188 1221.04 ms 1246.91 ms 25.87 ms
cc14e49 1209.31 ms 1231.54 ms 22.24 ms

App size

Revision Plain With Sentry Diff
f09e892 22.31 KiB 820.98 KiB 798.67 KiB
38ae188 22.31 KiB 820.94 KiB 798.63 KiB
cc14e49 22.31 KiB 821.57 KiB 799.26 KiB

Previous results on branch: armcknight/feat(feedback)/initial-release

Startup times

Revision Plain With Sentry Diff
331f1be 1197.30 ms 1229.26 ms 31.96 ms
588c9d0 1243.65 ms 1258.61 ms 14.96 ms
2b6f0d6 1221.55 ms 1234.17 ms 12.62 ms

App size

Revision Plain With Sentry Diff
331f1be 22.31 KiB 821.88 KiB 799.56 KiB
588c9d0 22.31 KiB 821.59 KiB 799.28 KiB
2b6f0d6 22.31 KiB 821.70 KiB 799.39 KiB

@armcknight armcknight force-pushed the armcknight/feat(feedback)/initial-release branch from 4957680 to e474fea Compare February 20, 2025 03:01
@armcknight armcknight force-pushed the armcknight/feat(feedback)/initial-release branch from e474fea to 5957494 Compare February 20, 2025 03:16
@armcknight armcknight marked this pull request as ready for review February 20, 2025 23:33
Copy link
Contributor

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments, but other than that LGTM

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a couple of things to improve, but nothing blocking.

Base automatically changed from armcknight/feat(feedback)/final-fixes to main February 22, 2025 00:21
@armcknight armcknight merged commit 124e4ab into main Feb 25, 2025
71 of 74 checks passed
@armcknight armcknight deleted the armcknight/feat(feedback)/initial-release branch February 25, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants