Skip to content

Expose SentrySessionReplayIntegration-Hybrid.h as private #4486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 30, 2024

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Oct 29, 2024

📜 Description

Expose SentrySessionReplayIntegration-Hybrid.h as private

💡 Motivation and Context

We need this to be accessible when integrating sentry through SPM in flutter.

💚 How did you test it?

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

Sorry, something went wrong.

Copy link
Contributor

github-actions bot commented Oct 29, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 8d8f901

@denrase denrase marked this pull request as ready for review October 29, 2024 16:20
@denrase
Copy link
Collaborator Author

denrase commented Oct 29, 2024

@brustolin I checked the flutter/ios folder where we have our plugin. From what i could tell, this is the only file where we still miss access to that is part of the HybridSDK folder.

@denrase denrase enabled auto-merge (squash) October 30, 2024 09:07
@denrase denrase merged commit 0c44375 into main Oct 30, 2024
41 checks passed
@denrase denrase deleted the feat/hybrid-sdk-private-headers branch October 30, 2024 09:31
brustolin added a commit that referenced this pull request Dec 3, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
This PR fixes access to SessionReplayIntegration from Hybrid SDK after #4440 #4486
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants