-
-
Notifications
You must be signed in to change notification settings - Fork 358
feat: Replay for crashes #4171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Replay for crashes #4171
Conversation
|
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
…entry/sentry-cocoa into feat(SR)/replay-for-crashes
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
0af45a9 | 1225.75 ms | 1245.38 ms | 19.63 ms |
4259afd | 1234.04 ms | 1256.76 ms | 22.72 ms |
7fe37ab | 1228.92 ms | 1243.86 ms | 14.94 ms |
2719ce6 | 1211.75 ms | 1237.16 ms | 25.41 ms |
d3edf46 | 1213.00 ms | 1227.46 ms | 14.46 ms |
1bd0055 | 1207.57 ms | 1223.10 ms | 15.53 ms |
ba4d16f | 1236.90 ms | 1252.12 ms | 15.22 ms |
556c407 | 1256.56 ms | 1274.60 ms | 18.04 ms |
42ef6ba | 1234.35 ms | 1252.29 ms | 17.94 ms |
2de284c | 1234.92 ms | 1254.45 ms | 19.53 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
0af45a9 | 21.58 KiB | 631.19 KiB | 609.61 KiB |
4259afd | 20.76 KiB | 419.70 KiB | 398.94 KiB |
7fe37ab | 21.58 KiB | 542.28 KiB | 520.70 KiB |
2719ce6 | 20.76 KiB | 435.13 KiB | 414.37 KiB |
d3edf46 | 20.76 KiB | 436.65 KiB | 415.89 KiB |
1bd0055 | 20.76 KiB | 420.22 KiB | 399.46 KiB |
ba4d16f | 20.76 KiB | 437.12 KiB | 416.36 KiB |
556c407 | 22.85 KiB | 413.98 KiB | 391.13 KiB |
42ef6ba | 21.58 KiB | 417.86 KiB | 396.28 KiB |
2de284c | 21.58 KiB | 542.39 KiB | 520.80 KiB |
Previous results on branch: feat(SR)/replay-for-crashes
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
c4968e8 | 1235.15 ms | 1240.56 ms | 5.41 ms |
4e094da | 1234.02 ms | 1249.94 ms | 15.92 ms |
2087b3a | 1209.91 ms | 1229.59 ms | 19.68 ms |
24df457 | 1234.08 ms | 1247.56 ms | 13.48 ms |
2dfce84 | 1235.27 ms | 1251.76 ms | 16.49 ms |
8ce2896 | 1236.67 ms | 1253.31 ms | 16.63 ms |
8c670b9 | 1234.15 ms | 1245.26 ms | 11.11 ms |
e849a60 | 1225.57 ms | 1232.11 ms | 6.53 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
c4968e8 | 21.58 KiB | 693.35 KiB | 671.77 KiB |
4e094da | 21.58 KiB | 693.24 KiB | 671.66 KiB |
2087b3a | 21.58 KiB | 692.47 KiB | 670.89 KiB |
24df457 | 21.58 KiB | 693.66 KiB | 672.08 KiB |
2dfce84 | 21.58 KiB | 692.33 KiB | 670.75 KiB |
8ce2896 | 21.58 KiB | 693.65 KiB | 672.07 KiB |
8c670b9 | 21.58 KiB | 693.33 KiB | 671.75 KiB |
e849a60 | 21.58 KiB | 693.51 KiB | 671.92 KiB |
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4171 +/- ##
=============================================
- Coverage 91.402% 91.388% -0.015%
=============================================
Files 606 606
Lines 48690 48875 +185
Branches 17567 17596 +29
=============================================
+ Hits 44504 44666 +162
- Misses 4093 4116 +23
Partials 93 93
... and 17 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
…entry/sentry-cocoa into feat(SR)/replay-for-crashes
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass just looking at the code. I plan to come back around and try running the tests and poking things.
Sources/Swift/Integrations/SessionReplay/SentryOnDemandReplay.swift
Outdated
Show resolved
Hide resolved
Sources/Swift/Integrations/SessionReplay/SentryOnDemandReplay.swift
Outdated
Show resolved
Hide resolved
Sources/Swift/Integrations/SessionReplay/SentryOnDemandReplay.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Andrew McKnight <andrew.mcknight@sentry.io>
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a couple outstanding questions about threading and UIScene but don't think those should hold up this PR at this point; we should continue that discussion separately and fix any issues we uncover in a subsequent PR. Thanks for the work here!
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
📜 Description
Send the replay for the final moments before a crash.
💚 How did you test it?
Sample and Unit tests
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps