-
-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reportFullyDisplayed data race #3926
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a data race when calling reportFullyDisplayed from a background thread by synchronizing the call to the main queue.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3926 +/- ##
=============================================
- Coverage 90.846% 90.802% -0.045%
=============================================
Files 593 592 -1
Lines 46028 45949 -79
Branches 16432 16363 -69
=============================================
- Hits 41815 41723 -92
- Misses 4034 4045 +11
- Partials 179 181 +2
... and 19 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
f74904f | 1229.02 ms | 1244.91 ms | 15.89 ms |
591a01b | 1242.69 ms | 1259.98 ms | 17.29 ms |
60dd0f5 | 1212.24 ms | 1240.82 ms | 28.58 ms |
e1cd9e9 | 1190.64 ms | 1221.90 ms | 31.26 ms |
5f8ee7a | 1249.48 ms | 1252.20 ms | 2.72 ms |
69d8759 | 1229.88 ms | 1240.45 ms | 10.57 ms |
e89dc54 | 1207.86 ms | 1218.27 ms | 10.41 ms |
f801098 | 1225.41 ms | 1237.45 ms | 12.04 ms |
c0b4b71 | 1218.16 ms | 1251.28 ms | 33.12 ms |
bbcbaff | 1216.82 ms | 1242.34 ms | 25.52 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
f74904f | 21.58 KiB | 418.71 KiB | 397.12 KiB |
591a01b | 22.84 KiB | 401.67 KiB | 378.83 KiB |
60dd0f5 | 20.76 KiB | 393.37 KiB | 372.61 KiB |
e1cd9e9 | 22.85 KiB | 412.95 KiB | 390.10 KiB |
5f8ee7a | 22.85 KiB | 411.93 KiB | 389.08 KiB |
69d8759 | 20.76 KiB | 393.05 KiB | 372.29 KiB |
e89dc54 | 22.85 KiB | 412.60 KiB | 389.75 KiB |
f801098 | 21.58 KiB | 614.71 KiB | 593.13 KiB |
c0b4b71 | 20.76 KiB | 430.98 KiB | 410.22 KiB |
bbcbaff | 22.85 KiB | 414.09 KiB | 391.24 KiB |
brustolin
reviewed
May 2, 2024
brustolin
approved these changes
May 6, 2024
62422f8
to
d308494
Compare
threema-matteo
pushed a commit
to threema-ch/sentry-cocoa
that referenced
this pull request
May 21, 2024
Fix a data race when calling reportFullyDisplayed from a background thread by synchronizing the call to the main queue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Fix a data race when calling reportFullyDisplayed from a background thread by synchronizing the call to the main queue.
💡 Motivation and Context
This came up when enabling the thread sanitizer for the iOS-Swift sample app and navigating to the LoremIpsum screen.
💚 How did you test it?
Unit tests and thread sanitizer in the iOS-Swift sample app.
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps