Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metrics): Data Normalization #3843

Merged
merged 4 commits into from
Apr 10, 2024
Merged

Conversation

philipphofmann
Copy link
Member

📜 Description

Update metrics data normalization to spec.

💡 Motivation and Context

Fixes GH-3829

💚 How did you test it?

Unit tests

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Update metrics data normalization to spec.

Fixes GH-3829
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.964%. Comparing base (c0f08e7) to head (02925a8).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3843       +/-   ##
=============================================
+ Coverage   90.948%   90.964%   +0.016%     
=============================================
  Files          560       560               
  Lines        44256     44271       +15     
  Branches     15779     15776        -3     
=============================================
+ Hits         40250     40271       +21     
+ Misses        3936      3820      -116     
- Partials        70       180      +110     
Files Coverage Δ
Sources/Swift/Metrics/EncodeMetrics.swift 100.000% <100.000%> (ø)
.../SentryTests/Swift/Metrics/EncodeMetricTests.swift 100.000% <100.000%> (ø)

... and 33 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0f08e7...02925a8. Read the comment docs.

Copy link

github-actions bot commented Apr 9, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1233.33 ms 1250.23 ms 16.90 ms
Size 21.58 KiB 574.17 KiB 552.59 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8838e54 1252.06 ms 1258.20 ms 6.14 ms
b15521e 1246.51 ms 1262.96 ms 16.45 ms
89b12eb 1236.02 ms 1246.63 ms 10.61 ms
45d3ca5 1248.27 ms 1255.48 ms 7.21 ms
42ef6ba 1201.67 ms 1214.35 ms 12.67 ms
742d4b6 1230.41 ms 1247.23 ms 16.83 ms
46267d8 1229.80 ms 1244.16 ms 14.37 ms
443723a 1205.24 ms 1220.52 ms 15.28 ms
e90aa6d 1277.38 ms 1303.18 ms 25.81 ms
f25febb 1224.69 ms 1247.38 ms 22.68 ms

App size

Revision Plain With Sentry Diff
8838e54 22.85 KiB 413.45 KiB 390.60 KiB
b15521e 21.58 KiB 573.17 KiB 551.59 KiB
89b12eb 20.76 KiB 432.88 KiB 412.11 KiB
45d3ca5 20.76 KiB 427.54 KiB 406.78 KiB
42ef6ba 21.58 KiB 417.86 KiB 396.28 KiB
742d4b6 21.58 KiB 546.20 KiB 524.62 KiB
46267d8 21.58 KiB 572.21 KiB 550.63 KiB
443723a 20.76 KiB 414.44 KiB 393.68 KiB
e90aa6d 21.58 KiB 418.82 KiB 397.24 KiB
f25febb 21.58 KiB 414.92 KiB 393.34 KiB

@philipphofmann philipphofmann merged commit e8114e4 into main Apr 10, 2024
68 of 70 checks passed
@philipphofmann philipphofmann deleted the fix/metrics-normalization branch April 10, 2024 10:23
dKasabwala pushed a commit to dKasabwala/sentry-cocoa that referenced this pull request May 6, 2024
Update metrics data normalization to spec.

Fixes getsentryGH-3829
threema-matteo pushed a commit to threema-ch/sentry-cocoa that referenced this pull request May 21, 2024
Update metrics data normalization to spec.

Fixes getsentryGH-3829
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics Normalization
2 participants