-
-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Release framework with no link to UIKit #3793
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3793 +/- ##
=============================================
- Coverage 89.585% 88.114% -1.471%
=============================================
Files 560 559 -1
Lines 60685 60319 -366
Branches 21828 21185 -643
=============================================
- Hits 54365 53150 -1215
- Misses 5285 6247 +962
+ Partials 1035 922 -113
... and 119 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d40512b | 1231.12 ms | 1244.54 ms | 13.42 ms |
7ce3cf6 | 1217.98 ms | 1246.41 ms | 28.43 ms |
25a5e8b | 1249.18 ms | 1268.42 ms | 19.24 ms |
533859f | 1211.33 ms | 1228.76 ms | 17.43 ms |
7fb7afb | 1227.73 ms | 1243.16 ms | 15.43 ms |
7cd187e | 1196.51 ms | 1226.04 ms | 29.53 ms |
0f30019 | 1239.22 ms | 1240.04 ms | 0.82 ms |
d61b939 | 1238.61 ms | 1240.08 ms | 1.47 ms |
98cca71 | 1199.08 ms | 1227.36 ms | 28.28 ms |
3bc6371 | 1205.00 ms | 1222.14 ms | 17.14 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d40512b | 20.76 KiB | 427.77 KiB | 407.00 KiB |
7ce3cf6 | 22.85 KiB | 407.63 KiB | 384.78 KiB |
25a5e8b | 20.76 KiB | 436.33 KiB | 415.57 KiB |
533859f | 22.85 KiB | 408.84 KiB | 385.99 KiB |
7fb7afb | 20.76 KiB | 419.70 KiB | 398.94 KiB |
7cd187e | 20.76 KiB | 401.66 KiB | 380.90 KiB |
0f30019 | 22.84 KiB | 405.39 KiB | 382.54 KiB |
d61b939 | 22.85 KiB | 407.63 KiB | 384.78 KiB |
98cca71 | 22.85 KiB | 411.14 KiB | 388.29 KiB |
3bc6371 | 21.58 KiB | 418.69 KiB | 397.11 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have UIKit on macOS, but instead, we have AppKit. Our SDK includes headers to Cocoa.h, but we only use NSApplication notification names. Therefore, we should be able to replace all Cocoa.h imports with #import <AppKit/AppKit.h>
. So, let's reflect that in the framework name, as pointed out in the comments.
Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Creates a framework with no link to UIKit to distribute as a GH release asset --------- Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>
📜 Description
Creates a framework with no link to UIKit to distribute as a GH release asset.
💡 Motivation and Context
closes #3768