Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Release framework with no link to UIKit #3793

Merged
merged 8 commits into from
Mar 27, 2024
Merged

Conversation

brustolin
Copy link
Contributor

📜 Description

Creates a framework with no link to UIKit to distribute as a GH release asset.

💡 Motivation and Context

closes #3768

Copy link

github-actions bot commented Mar 26, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 0b42365

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.114%. Comparing base (542727d) to head (9a0ea84).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3793       +/-   ##
=============================================
- Coverage   89.585%   88.114%   -1.471%     
=============================================
  Files          560       559        -1     
  Lines        60685     60319      -366     
  Branches     21828     21185      -643     
=============================================
- Hits         54365     53150     -1215     
- Misses        5285      6247      +962     
+ Partials      1035       922      -113     
Files Coverage Δ
Sources/Sentry/SentryBreadcrumbTracker.m 65.789% <100.000%> (ø)
Sources/Sentry/SentryDependencyContainer.m 91.570% <100.000%> (-3.832%) ⬇️
Sources/Sentry/SentryHttpTransport.m 97.747% <100.000%> (ø)
Sources/Sentry/SentryNSNotificationCenterWrapper.m 81.818% <ø> (ø)
Sources/Sentry/SentryReachability.m 98.529% <ø> (ø)
Sources/Sentry/SentrySessionTracker.m 100.000% <100.000%> (ø)

... and 119 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 542727d...9a0ea84. Read the comment docs.

Copy link

github-actions bot commented Mar 26, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1201.70 ms 1211.37 ms 9.67 ms
Size 21.58 KiB 571.91 KiB 550.33 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d40512b 1231.12 ms 1244.54 ms 13.42 ms
7ce3cf6 1217.98 ms 1246.41 ms 28.43 ms
25a5e8b 1249.18 ms 1268.42 ms 19.24 ms
533859f 1211.33 ms 1228.76 ms 17.43 ms
7fb7afb 1227.73 ms 1243.16 ms 15.43 ms
7cd187e 1196.51 ms 1226.04 ms 29.53 ms
0f30019 1239.22 ms 1240.04 ms 0.82 ms
d61b939 1238.61 ms 1240.08 ms 1.47 ms
98cca71 1199.08 ms 1227.36 ms 28.28 ms
3bc6371 1205.00 ms 1222.14 ms 17.14 ms

App size

Revision Plain With Sentry Diff
d40512b 20.76 KiB 427.77 KiB 407.00 KiB
7ce3cf6 22.85 KiB 407.63 KiB 384.78 KiB
25a5e8b 20.76 KiB 436.33 KiB 415.57 KiB
533859f 22.85 KiB 408.84 KiB 385.99 KiB
7fb7afb 20.76 KiB 419.70 KiB 398.94 KiB
7cd187e 20.76 KiB 401.66 KiB 380.90 KiB
0f30019 22.84 KiB 405.39 KiB 382.54 KiB
d61b939 22.85 KiB 407.63 KiB 384.78 KiB
98cca71 22.85 KiB 411.14 KiB 388.29 KiB
3bc6371 21.58 KiB 418.69 KiB 397.11 KiB

Previous results on branch: feat/release-nouikit

Startup times

Revision Plain With Sentry Diff
9c28899 1193.47 ms 1206.50 ms 13.03 ms
5ded27e 1231.35 ms 1240.58 ms 9.23 ms

App size

Revision Plain With Sentry Diff
9c28899 21.58 KiB 547.62 KiB 526.04 KiB
5ded27e 21.58 KiB 571.84 KiB 550.26 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have UIKit on macOS, but instead, we have AppKit. Our SDK includes headers to Cocoa.h, but we only use NSApplication notification names. Therefore, we should be able to replace all Cocoa.h imports with #import <AppKit/AppKit.h>. So, let's reflect that in the framework name, as pointed out in the comments.

CHANGELOG.md Outdated Show resolved Hide resolved
scripts/build-xcframework.sh Outdated Show resolved Hide resolved
brustolin and others added 2 commits March 27, 2024 11:09
Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
@brustolin brustolin merged commit 56baaef into main Mar 27, 2024
60 of 64 checks passed
@brustolin brustolin deleted the feat/release-nouikit branch March 27, 2024 15:15
threema-matteo pushed a commit to threema-ch/sentry-cocoa that referenced this pull request May 21, 2024
Creates a framework with no link to UIKit to distribute as a GH release asset
---------

Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ship an XCFramework without UIKit linked
2 participants