-
-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Metrics API #3791
feat: Add Metrics API #3791
Conversation
Add classes for Set, Gauge, and Distribution.
Add LocalMetricsAggregator, which is the foundation for correlating metrics to spans.
# Conflicts: # Sources/Swift/Metrics/LocalMetricsAggregator.swift
# Conflicts: # Sources/Swift/Metrics/LocalMetricsAggregator.swift # Tests/SentryTests/Swift/Metrics/LocalMetricsAggregatorTests.swift
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3791 +/- ##
=============================================
+ Coverage 89.473% 89.511% +0.038%
=============================================
Files 557 559 +2
Lines 60247 60542 +295
Branches 21669 21747 +78
=============================================
+ Hits 53905 54192 +287
- Misses 5306 5426 +120
+ Partials 1036 924 -112
... and 46 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I have just one suggestion.
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
01a28a9 | 1237.24 ms | 1253.24 ms | 16.00 ms |
60bfc91 | 1220.39 ms | 1250.89 ms | 30.50 ms |
8aba9c4 | 1236.94 ms | 1248.29 ms | 11.35 ms |
72c8d84 | 1257.34 ms | 1276.96 ms | 19.62 ms |
e90aa6d | 1277.38 ms | 1303.18 ms | 25.81 ms |
84fb4d9 | 1212.45 ms | 1223.39 ms | 10.94 ms |
98a8c16 | 1206.40 ms | 1232.14 ms | 25.74 ms |
ecd9ecd | 1191.76 ms | 1216.92 ms | 25.16 ms |
7cd187e | 1243.56 ms | 1250.20 ms | 6.64 ms |
2b55154 | 1231.36 ms | 1247.82 ms | 16.46 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
01a28a9 | 22.85 KiB | 405.39 KiB | 382.54 KiB |
60bfc91 | 20.76 KiB | 434.94 KiB | 414.18 KiB |
8aba9c4 | 21.58 KiB | 544.72 KiB | 523.14 KiB |
72c8d84 | 22.85 KiB | 408.88 KiB | 386.03 KiB |
e90aa6d | 21.58 KiB | 418.82 KiB | 397.24 KiB |
84fb4d9 | 22.84 KiB | 402.56 KiB | 379.72 KiB |
98a8c16 | 20.76 KiB | 431.00 KiB | 410.24 KiB |
ecd9ecd | 20.76 KiB | 420.23 KiB | 399.47 KiB |
7cd187e | 20.76 KiB | 401.65 KiB | 380.89 KiB |
2b55154 | 22.84 KiB | 402.19 KiB | 379.34 KiB |
The MetricsAPI for adding a set should accept a string, which gets converted to a CRC32 hash instead of an integer.
Add beta implementation of MetricsAPI. Fixes getsentryGH-3631
📜 Description
Add beta implementation of MetricsAPI.
💡 Motivation and Context
#3631
Docs PR getsentry/sentry-docs#9554.
💚 How did you test it?
Unit tests and simulator.
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps