-
-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Don't run onCrashedLastSession for nil Events #3785
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3785 +/- ##
=============================================
- Coverage 89.366% 89.345% -0.022%
=============================================
Files 548 548
Lines 59766 59786 +20
Branches 21474 21484 +10
=============================================
+ Hits 53411 53416 +5
- Misses 5315 5327 +12
- Partials 1040 1043 +3
... and 14 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 馃殌
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
01a28a9 | 1225.55 ms | 1249.96 ms | 24.41 ms |
de46f06 | 1255.53 ms | 1268.44 ms | 12.91 ms |
3f366ee | 1242.28 ms | 1260.80 ms | 18.52 ms |
75ef4eb | 1237.30 ms | 1249.53 ms | 12.23 ms |
72c8d84 | 1238.96 ms | 1247.34 ms | 8.38 ms |
105a36c | 1244.76 ms | 1249.12 ms | 4.36 ms |
b8dd0fc | 1235.57 ms | 1253.12 ms | 17.55 ms |
7cd187e | 1223.41 ms | 1249.40 ms | 26.00 ms |
3cb68af | 1221.15 ms | 1238.40 ms | 17.25 ms |
af1f4dd | 1238.08 ms | 1258.48 ms | 20.40 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
01a28a9 | 22.85 KiB | 405.39 KiB | 382.55 KiB |
de46f06 | 22.85 KiB | 414.74 KiB | 391.89 KiB |
3f366ee | 20.76 KiB | 427.84 KiB | 407.08 KiB |
75ef4eb | 22.85 KiB | 413.45 KiB | 390.60 KiB |
72c8d84 | 22.85 KiB | 408.88 KiB | 386.03 KiB |
105a36c | 22.85 KiB | 414.09 KiB | 391.24 KiB |
b8dd0fc | 20.76 KiB | 401.39 KiB | 380.63 KiB |
7cd187e | 20.76 KiB | 401.66 KiB | 380.89 KiB |
3cb68af | 20.76 KiB | 401.60 KiB | 380.84 KiB |
af1f4dd | 22.85 KiB | 414.71 KiB | 391.86 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense. Thanks @brustolin.
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Don't run onCrashedLastSession for nil Events ([#3785](https://github.com/getsentry/sentry-cocoa/pull/3785)) If none of the above apply, you can opt out of this check by adding |
Don't run onCrashedLastSession for nil Events. This could happen if beforeSend returns nil
馃摐 Description
Don't run onCrashedLastSession for nil Events. This could happen if
beforeSend
returns nil馃挕 Motivation and Context
closes #3784
馃挌 How did you test it?
Unit test
馃摑 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.馃敭 Next steps