Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Sentry.framework does not support the minimum OS Version specified in the Info.plist #3774

Merged
merged 9 commits into from
Mar 20, 2024

Conversation

brustolin
Copy link
Contributor

📜 Description

Static framework was failing Xcode validation because of minimum os version.

💡 Motivation and Context

close #3769

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @brustolin. One question.

scripts/build-xcframework.sh Show resolved Hide resolved
scripts/build-xcframework.sh Show resolved Hide resolved
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brustolin brustolin merged commit 626b91b into main Mar 20, 2024
25 checks passed
@brustolin brustolin deleted the fix/Static-framework branch March 20, 2024 16:23
@brustolin brustolin mentioned this pull request May 8, 2024
7 tasks
brustolin added a commit that referenced this pull request May 10, 2024
The hacky solution introduced in the PR #3774 is breaking compilation for Xcode 15.4

This solution will keep both Xcode 15 (.3 and .4) working.

I believe we can remove the version replacement after a few months after Xcode 15.4 release.
threema-matteo pushed a commit to threema-ch/sentry-cocoa that referenced this pull request May 21, 2024
…ed in the Info.plist (getsentry#3774)

Static framework was failing Xcode validation because of minimum os version
threema-matteo pushed a commit to threema-ch/sentry-cocoa that referenced this pull request May 21, 2024
The hacky solution introduced in the PR getsentry#3774 is breaking compilation for Xcode 15.4

This solution will keep both Xcode 15 (.3 and .4) working.

I believe we can remove the version replacement after a few months after Xcode 15.4 release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sentry.framework does not support the minimum OS Version specified in the Info.plist.
2 participants