Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Hybrid SDKs without SentryPrivate #3771

Merged
merged 5 commits into from
Mar 20, 2024
Merged

fix: Hybrid SDKs without SentryPrivate #3771

merged 5 commits into from
Mar 20, 2024

Conversation

brustolin
Copy link
Contributor

📜 Description

We need to update some references in order for HybridSDKs to work properly

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.283%. Comparing base (d9cd5f1) to head (4fb0591).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3771       +/-   ##
=============================================
+ Coverage   89.252%   89.283%   +0.030%     
=============================================
  Files          544       544               
  Lines        59300     59311       +11     
  Branches     21307     21315        +8     
=============================================
+ Hits         52927     52955       +28     
+ Misses        5333      5314       -19     
- Partials      1040      1042        +2     

see 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9cd5f1...4fb0591. Read the comment docs.

Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1231.93 ms 1238.16 ms 6.23 ms
Size 21.58 KiB 544.73 KiB 523.14 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
25e65a5 1249.08 ms 1277.78 ms 28.70 ms
60dd0f5 1247.35 ms 1267.59 ms 20.24 ms
83acf3e 1240.06 ms 1261.38 ms 21.31 ms
c021422 1237.12 ms 1263.18 ms 26.06 ms
bd2cb64 1216.14 ms 1241.78 ms 25.64 ms
8f397a7 1252.37 ms 1274.80 ms 22.43 ms
3ea21f5 1250.80 ms 1258.88 ms 8.08 ms
4053ee9 1248.04 ms 1250.82 ms 2.78 ms
bd2afa6 1241.37 ms 1246.20 ms 4.83 ms
51307b7 1223.08 ms 1240.76 ms 17.68 ms

App size

Revision Plain With Sentry Diff
25e65a5 22.85 KiB 403.19 KiB 380.34 KiB
60dd0f5 20.76 KiB 393.37 KiB 372.60 KiB
83acf3e 21.58 KiB 539.87 KiB 518.29 KiB
c021422 20.76 KiB 435.64 KiB 414.88 KiB
bd2cb64 22.85 KiB 413.45 KiB 390.60 KiB
8f397a7 20.76 KiB 420.55 KiB 399.79 KiB
3ea21f5 22.84 KiB 402.63 KiB 379.78 KiB
4053ee9 20.76 KiB 435.22 KiB 414.46 KiB
bd2afa6 20.76 KiB 420.55 KiB 399.79 KiB
51307b7 22.85 KiB 407.63 KiB 384.78 KiB

@brustolin brustolin marked this pull request as ready for review March 20, 2024 15:10
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brustolin brustolin merged commit 2ccbd03 into main Mar 20, 2024
26 checks passed
@brustolin brustolin deleted the fix/HybridSDK branch March 20, 2024 15:58
threema-matteo pushed a commit to threema-ch/sentry-cocoa that referenced this pull request May 21, 2024
* Update PrivateSentrySDKOnly.h

* Update CHANGELOG.md

* update podspec

* Update Sentry.podspec

* Update Sentry.podspec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants