-
-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Write NSException reason for crash report #3705
Conversation
Correctly write the NSException reason when writing a crash report. When writing a crash report for NSException the crash report writer wrote the crash reason to ReferencedObject, which didn't make any sense. This is fixed now by using the reason field. Fixes GH-3265
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3705 +/- ##
=============================================
- Coverage 89.299% 89.224% -0.075%
=============================================
Files 534 533 -1
Lines 58976 58706 -270
Branches 21175 20800 -375
=============================================
- Hits 52665 52380 -285
- Misses 5390 5400 +10
- Partials 921 926 +5
... and 91 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3297d6e | 1228.57 ms | 1255.04 ms | 26.47 ms |
6129be5 | 1215.65 ms | 1247.18 ms | 31.54 ms |
dacf894 | 1232.32 ms | 1236.34 ms | 4.02 ms |
7bbb7c3 | 1232.40 ms | 1249.78 ms | 17.38 ms |
ddc9b9a | 1210.00 ms | 1234.18 ms | 24.18 ms |
06548c0 | 1226.71 ms | 1252.37 ms | 25.66 ms |
ee8b48f | 1196.80 ms | 1213.48 ms | 16.68 ms |
881a955 | 1209.47 ms | 1225.94 ms | 16.47 ms |
8f397a7 | 1219.12 ms | 1236.67 ms | 17.55 ms |
f576153 | 1210.02 ms | 1228.94 ms | 18.92 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3297d6e | 21.58 KiB | 418.45 KiB | 396.86 KiB |
6129be5 | 21.58 KiB | 418.00 KiB | 396.42 KiB |
dacf894 | 20.76 KiB | 426.34 KiB | 405.58 KiB |
7bbb7c3 | 21.58 KiB | 418.78 KiB | 397.20 KiB |
ddc9b9a | 20.76 KiB | 420.40 KiB | 399.64 KiB |
06548c0 | 20.76 KiB | 427.36 KiB | 406.59 KiB |
ee8b48f | 21.58 KiB | 418.70 KiB | 397.11 KiB |
881a955 | 22.85 KiB | 407.63 KiB | 384.78 KiB |
8f397a7 | 20.76 KiB | 420.55 KiB | 399.79 KiB |
f576153 | 20.76 KiB | 425.77 KiB | 405.01 KiB |
Previous results on branch: fix/write-nsexception-reason
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
a90fed0 | 1235.18 ms | 1245.20 ms | 10.02 ms |
7c44990 | 1233.92 ms | 1246.12 ms | 12.21 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
a90fed0 | 21.58 KiB | 540.04 KiB | 518.46 KiB |
7c44990 | 21.58 KiB | 539.81 KiB | 518.23 KiB |
Tests/SentryTests/Integrations/SentryCrash/SentryCrashReportTests.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…sts.swift Co-authored-by: Dhiogo Brustolin <dhiogo.brustolin@sentry.io>
Correctly write the NSException reason when writing a crash report. When writing a crash report for NSException the crash report writer wrote the crash reason to ReferencedObject, which didn't make any sense. This is fixed now by using the reason field. Fixes getsentryGH-3265 Co-authored-by: Dhiogo Brustolin <dhiogo.brustolin@sentry.io>
📜 Description
Correctly write the NSException reason when writing a crash report. When writing a crash report for NSException the crash report writer wrote the crash reason to ReferencedObject, which didn't make any sense. This is fixed now by using the reason field.
💡 Motivation and Context
Fixes GH-3265
💚 How did you test it?
Unit tests.
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps