fix: Move header reference out of extern C

[brustolin]

📜 Description

Removing header references from extern C because they are causing compile errors with Android Studio and flutter.

💡 Motivation and Context

close getsentry/sentry-dart#1781

💚 How did you test it?

📝 Checklist

You have to check all boxes before merging:

• I reviewed the submitted code.
• I added tests to verify the changes.
• No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
• I updated the docs if needed.
• Review from the native team if needed.
• No breaking change or entry added to the changelog.
• No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (50bb751) 89.224% compared to head (d18153a) 89.246%.

Additional details and impacted files

@@              Coverage Diff              @@
##              main     #3538       +/-   ##
=============================================
+ Coverage   89.224%   89.246%   +0.021%     
=============================================
  Files          529       529               
  Lines        57697     57710       +13     
  Branches     20642     20647        +5     
=============================================
+ Hits         51480     51504       +24     
+ Misses        5306      5289       -17     
- Partials       911       917        +6     

Files	Coverage Δ
...yCrash/Recording/Tools/SentryCrashMachineContext.h	100.000% <ø> (ø)
...ntryCrash/Recording/Tools/SentryCrashStackCursor.h	100.000% <ø> (ø)

... and 17 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50bb751...d18153a. Read the comment docs.

[github-actions]

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1293.52 ms	1327.94 ms	34.42 ms
Size	21.58 KiB	417.85 KiB	396.27 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
e324230	1244.43 ms	1252.98 ms	8.55 ms
d760c3f	1200.95 ms	1233.96 ms	33.00 ms
5d6ce0e	1227.57 ms	1241.08 ms	13.51 ms
7cd187e	1223.41 ms	1249.40 ms	26.00 ms
407ff99	1216.63 ms	1235.50 ms	18.87 ms
dc0db9e	1246.06 ms	1260.46 ms	14.40 ms
881a955	1230.98 ms	1246.22 ms	15.24 ms
98cca71	1210.75 ms	1240.64 ms	29.89 ms
9faf217	1268.86 ms	1274.82 ms	5.96 ms
e1eed6b	1224.63 ms	1234.84 ms	10.20 ms

App size

Revision	Plain	With Sentry	Diff
e324230	22.85 KiB	408.88 KiB	386.03 KiB
d760c3f	22.84 KiB	403.17 KiB	380.33 KiB
5d6ce0e	22.85 KiB	405.38 KiB	382.53 KiB
7cd187e	20.76 KiB	401.66 KiB	380.89 KiB
407ff99	20.76 KiB	427.87 KiB	407.10 KiB
dc0db9e	20.76 KiB	419.62 KiB	398.86 KiB
881a955	22.85 KiB	407.63 KiB	384.79 KiB
98cca71	22.85 KiB	411.14 KiB	388.29 KiB
9faf217	20.76 KiB	419.70 KiB	398.94 KiB
e1eed6b	20.76 KiB	432.17 KiB	411.41 KiB

Previous results on branch: fix/c-extern

Startup times

Revision	Plain	With Sentry	Diff
0d66751	1227.15 ms	1243.82 ms	16.66 ms
6caebaa	1228.79 ms	1242.29 ms	13.50 ms

App size

Revision	Plain	With Sentry	Diff
0d66751	21.58 KiB	417.86 KiB	396.28 KiB
6caebaa	21.58 KiB	418.70 KiB	397.12 KiB

[philipphofmann]

Can we add something in CI that prevents that mistake in the future? What else is missing so we can merge this @brustolin?

[brustolin]

Can we add something in CI that prevents that mistake in the future? What else is missing so we can merge this @brustolin?

This is kind of a shot in the dark. Everything I read about it says it's okay (or we should) to move the includes out of extern C. CI is not complaining about it, and other tests where I forced the file to use a C++ compiler were okay. But I could not reproduce the error before the changes.

I'm waiting for the user to test this branch; I sent them instructions in the original issue.

[kahest]

The user in getsentry/sentry-dart#1781 (comment) reported that this fixed their issue

[philipphofmann]

LGTM