New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove "/" from crash report file name #3005
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3005 +/- ##
=============================================
- Coverage 88.371% 88.348% -0.023%
=============================================
Files 495 495
Lines 53264 53231 -33
Branches 19141 19114 -27
=============================================
- Hits 47070 47029 -41
- Misses 5237 5240 +3
- Partials 957 962 +5
... and 16 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
326b7eb | 1252.86 ms | 1259.56 ms | 6.70 ms |
c6504da | 1232.06 ms | 1243.28 ms | 11.22 ms |
d3abae0 | 1200.36 ms | 1224.22 ms | 23.87 ms |
630ddf4 | 1216.50 ms | 1235.94 ms | 19.44 ms |
5de0a56 | 1214.49 ms | 1235.56 ms | 21.07 ms |
407ff99 | 1216.63 ms | 1235.50 ms | 18.87 ms |
005bb4c | 1237.38 ms | 1255.54 ms | 18.16 ms |
7fb7afb | 1230.12 ms | 1251.04 ms | 20.92 ms |
cf724da | 1243.14 ms | 1261.44 ms | 18.30 ms |
3f1be0f | 1208.12 ms | 1225.72 ms | 17.60 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
326b7eb | 20.76 KiB | 432.31 KiB | 411.55 KiB |
c6504da | 20.76 KiB | 414.44 KiB | 393.69 KiB |
d3abae0 | 20.76 KiB | 434.92 KiB | 414.16 KiB |
630ddf4 | 20.76 KiB | 432.37 KiB | 411.61 KiB |
5de0a56 | 20.76 KiB | 432.87 KiB | 412.11 KiB |
407ff99 | 20.76 KiB | 427.87 KiB | 407.10 KiB |
005bb4c | 20.76 KiB | 419.70 KiB | 398.94 KiB |
7fb7afb | 20.76 KiB | 419.70 KiB | 398.94 KiB |
cf724da | 20.76 KiB | 430.52 KiB | 409.76 KiB |
3f1be0f | 20.76 KiB | 414.44 KiB | 393.69 KiB |
…coa into fix/dash-in-the-name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @brustolin.
Edit: I got mixed up, this is for bundle name, not bundle identifier. |
📜 Description
Crash report uses bundleName to create the report file, but "/" is a valid character for bundle name but not for file name.
Replace "/" with "-" for the report file name.
💡 Motivation and Context
Close #2975
💚 How did you test it?
Unit test and sample.
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps