chore: Remove confusing transaction tag

[brustolin]

Removed __sentry_transaction added to the scope during viewDidAppear.
Now we have automatic view controller transactions and this tag is confusing hack

[github-actions]

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1224.71 ms	1248.98 ms	24.27 ms
Size	20.76 KiB	404.75 KiB	383.98 KiB

Baseline results on branch: 8.0.0

Startup times

Revision	Plain	With Sentry	Diff
5da2d48	1209.52 ms	1232.16 ms	22.64 ms
a9db8a6	1199.83 ms	1234.56 ms	34.73 ms
58ec104	1244.29 ms	1269.67 ms	25.39 ms
b9c9598	1228.57 ms	1251.10 ms	22.53 ms
b696ae1	1229.64 ms	1246.94 ms	17.30 ms
838ad6b	1230.69 ms	1268.27 ms	37.58 ms
04beb80	1215.37 ms	1249.31 ms	33.95 ms
22952c8	1249.56 ms	1257.06 ms	7.50 ms
4dc66f6	1202.59 ms	1228.34 ms	25.75 ms
6c7ab81	1231.66 ms	1251.58 ms	19.92 ms

App size

Revision	Plain	With Sentry	Diff
5da2d48	20.75 KiB	383.77 KiB	363.01 KiB
a9db8a6	20.75 KiB	383.37 KiB	362.62 KiB
58ec104	20.75 KiB	379.11 KiB	358.36 KiB
b9c9598	20.75 KiB	383.77 KiB	363.01 KiB
b696ae1	20.75 KiB	383.77 KiB	363.01 KiB
838ad6b	20.75 KiB	405.10 KiB	384.34 KiB
04beb80	20.75 KiB	404.84 KiB	384.09 KiB
22952c8	20.75 KiB	401.81 KiB	381.05 KiB
4dc66f6	20.75 KiB	381.81 KiB	361.06 KiB
6c7ab81	20.75 KiB	405.10 KiB	384.34 KiB

Previous results on branch: chore/remove-Confusing-transaction-tag

Startup times

Revision	Plain	With Sentry	Diff
364dcd3	1225.32 ms	1235.22 ms	9.90 ms

App size

Revision	Plain	With Sentry	Diff
364dcd3	20.76 KiB	404.75 KiB	383.98 KiB

[philipphofmann]

Please add a changelog entry for breaking change. Apart from that LGTM

[codecov]

Codecov Report

Merging #2574 (c74b861) into 8.0.0 (afcb16a) will decrease coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##            8.0.0    #2574      +/-   ##
==========================================
- Coverage   79.18%   79.18%   -0.01%     
==========================================
  Files         243      243              
  Lines       22292    22291       -1     
  Branches     9869     9862       -7     
==========================================
- Hits        17652    17651       -1     
+ Misses       4189     4188       -1     
- Partials      451      452       +1     

Impacted Files	Coverage Δ
Sources/Sentry/SentryBreadcrumbTracker.m	76.82% <ø> (-0.42%)	⬇️
Sources/Sentry/SentryEvent.m	98.26% <ø> (-0.03%)	⬇️
Sources/Sentry/SentryThreadInspector.m	95.87% <0.00%> (-2.07%)	⬇️
Sources/Sentry/SentryBacktrace.cpp	86.60% <0.00%> (-1.79%)	⬇️
Sources/Sentry/SentryNetworkTracker.m	95.33% <0.00%> (-0.07%)	⬇️
Sources/Sentry/SentryANRTracker.m	100.00% <0.00%> (ø)
Sources/Sentry/SentryRequestOperation.m	78.37% <0.00%> (+10.81%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afcb16a...c74b861. Read the comment docs.

[philipphofmann]

LGTM