Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable bitcode #2307

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Enable bitcode #2307

merged 2 commits into from
Oct 20, 2022

Conversation

brustolin
Copy link
Contributor

馃摐 Description

Manually enabled bitcode

馃挕 Motivation and Context

Xcode 14 changed the default value for BitCote to 'NO', now our framework generated with Carthage don't have the bitcode information and this causes warning on customer projects that uses bitcode.

closes #2304

馃挌 How did you test it?

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • Review from the native team if needed
  • No breaking changes

馃敭 Next steps

@brustolin
Copy link
Contributor Author

I believe we need to make a new release after this to update the zipped framework.

@github-actions
Copy link

github-actions bot commented Oct 20, 2022

Performance metrics 馃殌

Plain With Sentry Diff
Startup time 1213.60 ms 1237.92 ms 24.32 ms
Size 20.50 KiB 338.99 KiB 318.49 KiB

Baseline results on branch: master

Startup times

Revision Plain With Sentry Diff
b869536 1250.37 ms 1274.84 ms 24.47 ms
372ffbe 1225.68 ms 1243.02 ms 17.34 ms
be47c6c 1222.73 ms 1241.63 ms 18.90 ms
0fdf0b2 1266.27 ms 1277.90 ms 11.63 ms
5ecf9f6 1230.76 ms 1232.86 ms 2.10 ms
b15627c 1212.65 ms 1237.88 ms 25.23 ms
0fdf0b2 1245.88 ms 1247.69 ms 1.82 ms
4a0c282 1228.60 ms 1250.74 ms 22.14 ms
9231f60 1256.78 ms 1267.74 ms 10.96 ms
5025d2e 1248.52 ms 1251.72 ms 3.20 ms

App size

Revision Plain With Sentry Diff
b869536 20.51 KiB 331.79 KiB 311.28 KiB
372ffbe 20.50 KiB 335.95 KiB 315.44 KiB
be47c6c 20.50 KiB 333.54 KiB 313.04 KiB
0fdf0b2 20.51 KiB 332.90 KiB 312.39 KiB
5ecf9f6 20.51 KiB 332.66 KiB 312.15 KiB
b15627c 20.50 KiB 337.76 KiB 317.26 KiB
0fdf0b2 20.51 KiB 332.90 KiB 312.39 KiB
4a0c282 20.51 KiB 333.10 KiB 312.60 KiB
9231f60 20.51 KiB 333.58 KiB 313.07 KiB
5025d2e 20.51 KiB 331.79 KiB 311.28 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brustolin brustolin merged commit ae4f9dd into master Oct 20, 2022
@brustolin brustolin deleted the fix/enable-bitcode branch October 20, 2022 12:42
@username0x0a
Copy link

According to Apple, Bitcode is rather considered as deprecated 馃 at least when already using Xcode 14 to build (which should be a requirement early the next year for App Store submissions), see the section and further notes there. So I guess it can be reverted pretty soon. 馃槃

@philipphofmann
Copy link
Member

@brustolin, I think you are the best person to answer the question above 猬嗭笍 .

@brustolin
Copy link
Contributor Author

@username0x0a Yeap, we're not aware of the new rule "no bitcode" for new app submission. This was reverted already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XCFramework: Missing Bitcode for iOS
3 participants