Skip to content

fix: Support for arm64 architecture #2185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 19, 2022
Merged

fix: Support for arm64 architecture #2185

merged 5 commits into from
Sep 19, 2022
+4 −0

Conversation

kevinrenskers
Copy link
Contributor

📜 Description

Add support for the arm64 architecture by adding a missing case to the switch.

💡 Motivation and Context

Closes #1226

💚 How did you test it?

Manually by running on an iPhone 12 mini

Screen Shot 2022-09-19 at 11 37 13

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • Review from the native team if needed
  • No breaking changes

🔮 Next steps

Sorry, something went wrong.

@kevinrenskers
fix: Support for arm64 architecture

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 18BB26FC07101007
Learn about vigilant mode
64ff9d3 
Closes #1226
@kevinrenskers
Changelog

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 18BB26FC07101007
Learn about vigilant mode
ed7a02c
@kevinrenskers
Improve the changelog

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 18BB26FC07101007
Learn about vigilant mode
8fedb1f
brustolin
brustolin approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

philipphofmann
philipphofmann approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, hard to test so no test is okay.

@kevinrenskers
Merge branch 'master' into fix/arm64-architecture

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 18BB26FC07101007
Learn about vigilant mode
372d7be 
* master:
  test: Update vapor to 4.65.2 (#2179)
@kevinrenskers
Copy link
Contributor Author

Yeah I searched for any existing tests, but couldn't find any.

@kevinrenskers
Copy link
Contributor Author

kevinrenskers commented Sep 19, 2022 •
edited
Loading

What's going on with SentryNetworkTrackerIntegrationTests.testGetRequest_SpanCreatedAndTraceHeaderAdded?

SentryTests.SentryNetworkTrackerIntegrationTests
  testGetRequest_SpanCreatedAndTraceHeaderAdded, XCTAssertEqual failed: ("Hello, world! Trace header added.") is not equal to ("")
  testGetRequest_SpanCreatedAndTraceHeaderAdded, XCTAssertEqual failed: ("Optional("200")") is not equal to ("nil")

@kevinrenskers
Merge branch 'master' into fix/arm64-architecture

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 18BB26FC07101007
Learn about vigilant mode
0766e66 
* master:
  ci: Compile test-server once (#2180)
@kevinrenskers kevinrenskers merged commit 4d96807 into master Sep 19, 2022
@kevinrenskers kevinrenskers deleted the fix/arm64-architecture branch September 19, 2022 12:44
kevinrenskers added a commit that referenced this pull request Sep 19, 2022
@kevinrenskers
Merge branch 'master' into feat/more-device-context

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 18BB26FC07101007
Learn about vigilant mode
31d6edc 
* master:
  meta: Automatically manage signing (#2184)
  fix: Support for arm64 architecture (#2185)
  meta: Contributing md lint fixes (#2186)
  feat: Add flush (#2140)
@philipphofmann philipphofmann mentioned this pull request Sep 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipphofmann philipphofmann

@brustolin brustolin

@armcknight armcknight

@indragiek indragiek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CPU Architecture is missing on some devices
3 participants
@kevinrenskers @philipphofmann @brustolin