Skip to content

fix: pull environment from where its currently written at profile serialization time #2095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 30, 2022
Merged

fix: pull environment from where its currently written at profile serialization time #2095

merged 8 commits into from
Aug 30, 2022
+265 −149

Conversation

armcknight
Copy link
Member

@github-actions
Copy link
Contributor

github-actions bot commented Aug 19, 2022 •
edited
Loading

Performance metrics 🚀

Plain With Sentry Diff
Startup time (ms) 1250.33 1261.02 10.69
Size (bytes) 21157 330737 309580

indragiek
indragiek reviewed Aug 19, 2022
View reviewed changes
Copy link
Member

@indragiek indragiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides adding a test!

@armcknight armcknight requested a review from indragiek August 22, 2022 21:10
@armcknight armcknight force-pushed the armcknight/add-scope-items-to-profiling-payloads branch from f609275 to 55c9f77 Compare August 23, 2022 18:21
armcknight and others added 6 commits August 29, 2022 12:46
@armcknight
fix: pull environment from where its currently written at profile ser…

Verified

This commit was signed with the committer’s verified signature.
armcknight Andrew McKnight
GPG key ID: FFCBF6226B729A75
Verified
Learn about vigilant mode
be965b2 
…ialization time
@getsentry-bot @armcknight
Format code

Verified

This commit was signed with the committer’s verified signature.
armcknight Andrew McKnight
GPG key ID: FFCBF6226B729A75
Verified
Learn about vigilant mode
fbda586
@armcknight
docs: update changelog

Verified

This commit was signed with the committer’s verified signature.
armcknight Andrew McKnight
GPG key ID: FFCBF6226B729A75
Verified
Learn about vigilant mode
f740957
@armcknight
ref: extract default environment to constant

Verified

This commit was signed with the committer’s verified signature.
armcknight Andrew McKnight
GPG key ID: FFCBF6226B729A75
Verified
Learn about vigilant mode
c8229be
@armcknight
test: add test to assert environment always makes it into profiling p…

Verified

This commit was signed with the committer’s verified signature.
armcknight Andrew McKnight
GPG key ID: FFCBF6226B729A75
Verified
Learn about vigilant mode
2f0666c 
…ayloads
@armcknight
fix: disable line length rule

Verified

This commit was signed with the committer’s verified signature.
armcknight Andrew McKnight
GPG key ID: FFCBF6226B729A75
Verified
Learn about vigilant mode
d6f40c1
@armcknight armcknight force-pushed the armcknight/add-scope-items-to-profiling-payloads branch from 55c9f77 to d6f40c1 Compare August 29, 2022 20:48
@armcknight
meta: merge fixes

Verified

This commit was signed with the committer’s verified signature.
armcknight Andrew McKnight
GPG key ID: FFCBF6226B729A75
Verified
Learn about vigilant mode
f57974f
@armcknight
meta: more merge fixes, typo fix

Verified

This commit was signed with the committer’s verified signature.
armcknight Andrew McKnight
GPG key ID: FFCBF6226B729A75
Verified
Learn about vigilant mode
93a7c5e
@armcknight armcknight merged commit 0ec4dfe into master Aug 30, 2022
@armcknight armcknight deleted the armcknight/add-scope-items-to-profiling-payloads branch August 30, 2022 16:02
kevinrenskers added a commit that referenced this pull request Sep 1, 2022
@kevinrenskers
Merge branch 'master' into feat/2026-app-permissions-from-extension

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 18BB26FC07101007
Learn about vigilant mode
7d68702 
* master:
  ci: Print Swift Version (#2112)
  ref: Improve logs for UIViewControllerSwizzling (#2111)
  fix: typo in string literal (#2110)
  release: 7.24.0-beta.0
  fix: pull `environment` from where its currently written at profile serialization time (#2095)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brustolin brustolin

@philipphofmann philipphofmann

@indragiek indragiek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@armcknight @indragiek @brustolin @getsentry-bot