feat: Add sample rate in the baggage header, remove Userid and Transaction #1936
Conversation
|
There was a problem hiding this comment.
LGTM, from an ObjC level, have no clue if this aligns with the dynamic sampling spec. Can someone else have a look, @brustolin? We still miss tests.
…ntry-cocoa into feat/baggage-update
…ntry-cocoa into feat/baggage-update
brustolin
changed the title
There was a problem hiding this comment.
Disclaimer: I have no idea about Objective C so take this with a grain of salt.
From what I saw when going through the PR, I think the names in the envelope header and the baggage Http header are correct. (Just to be sure, they should only differ by the sentry- prefix.)
Otherwise, this seems to conform to the spec (in the sense that we do need the sample_rate and we're not including user_id and transaction for the time being).
| if (_sampleRate != nil) | ||
| [information setValue:_sampleRate forKey:@"sentry-sample_rate"]; |
There was a problem hiding this comment.
Are we making sure here that the sentry-sample_rate is set as a simple decimal number (no exponential notation, NaN [if that's a thing in obj-c], etc)? (this applies to both, baggage and envelope header)
There was a problem hiding this comment.
Kind yes, because OBJ-C converter does not use exponential notation and dont have the NaN concept. So I would say we are good here.
* master: build: Remove trailing-whitespace (#1953) ci: Compile iOS13-Swift sample (#1951) release: 7.20.0 meta: Fix changelog (#1950) feat: Add sample rate in the baggage header, remove Userid and Transaction (#1936) build: Upate Brewfile.lock and Gemfile.lock (#1947) meta: Add Pre Commit Hook (#1946) ref: Remove unused SentryCrashDeadlock (#1941) feat: Add screenshot at crash (#1920) Add code docs for SentryScope (#1942)
|
@brustolin this is missing. |
📜 Description
Included the sample rate info in the baggage header.
Updated baggage header keys.
Checking PII before sharing user info in the baggage header.
💡 Motivation and Context
In preparation to dynamic sampling
💚 How did you test it?
Unit tests
📝 Checklist
🔮 Next steps