-
-
Notifications
You must be signed in to change notification settings - Fork 356
perf: Filter binary images on Sentry Crash #1767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@philipphofmann should we ping someone from native team to review this PR? |
Codecov Report
@@ Coverage Diff @@
## master #1767 +/- ##
==========================================
+ Coverage 91.74% 92.64% +0.89%
==========================================
Files 198 198
Lines 9004 9012 +8
==========================================
+ Hits 8261 8349 +88
+ Misses 743 663 -80
Continue to review full report at Codecov.
|
No, as this PR doesn't touch any C code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time for this big improvement. I added a few comments.
Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
📜 Description
Hard crash reports include all binary images, that's a lot of data. This change will filter only binary images that have some reference on any stack frame for any thread in the report, drastically reducing event payload.
💡 Motivation and Context
Part of #1676
💚 How did you test it?
Unit tests
📝 Checklist
🔮 Next steps