Skip to content

fix: Add verification for vendor UUID in OOM logic #1648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 27, 2022

Conversation

brustolin
Copy link
Contributor

@brustolin brustolin commented Jan 26, 2022

📜 Description

UIDevice has a identifierForVendor property that may change when the app is reinstalled or a build test installation is done using Xcode.

See Apple documentation.

💡 Motivation and Context

Adding an extra verification in the case of a vendor identifier change will reduce OOM false positives.

close #1334

💚 How did you test it?

Unit Test

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • Review from the native team if needed
  • No breaking changes

🔮 Next steps

Sorry, something went wrong.

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2022

Codecov Report

Merging #1648 (c3cd5a6) into master (9854751) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1648      +/-   ##
==========================================
- Coverage   96.01%   95.99%   -0.02%     
==========================================
  Files         162      162              
  Lines        7335     7349      +14     
==========================================
+ Hits         7043     7055      +12     
- Misses        292      294       +2     
Impacted Files Coverage Δ
Sources/Sentry/SentryAppState.m 100.00% <100.00%> (ø)
Sources/Sentry/SentryAppStateManager.m 100.00% <100.00%> (ø)
Sources/Sentry/SentryOutOfMemoryLogic.m 93.18% <100.00%> (-1.82%) ⬇️
Sources/Sentry/include/SentryAppState.h 100.00% <100.00%> (ø)
Sources/Sentry/SentryTracer.m 98.11% <0.00%> (-0.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9854751...c3cd5a6. Read the comment docs.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle UUID changes in device for false positive OOM
3 participants