fix: SpanProtocol add setData for Swift #1305
Merged
+37
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Swift didn't have a method for SpanProtocol.setData as the Swift name for
setData was setExtra by mistake. This is fixed now by adding an setExtra
for both Objective-C and Swift to avoid a breaking change. setExtra will
be deprecated and removed in future versions.
💡 Motivation and Context
I came across this issue when looking at the code.
💚 How did you test it?
Unit tests.
📝 Checklist
🔮 Next steps