fix: Swizzling crash on iOS 13 #1297
Merged
+18
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iOS 13 doesn't have a method for HTTPAdditionalHeaders. Instead, it only has a property. Therefore, the swizzling crashes on iOS 13. This is fixed now by checking if NSURLSessionConfiguration has a method HTTPAdditionalHeaders. The downside is that we don't add a trace header on iOS 13 anymore. This is better than crashing though. Fixes GH-1296
marandaneto
approved these changes
Aug 31, 2021
marandaneto
reviewed
Aug 31, 2021
Comment on lines
+38
to
+39
| // iOS 13 doesn't have a method for HTTPAdditionalHeaders. Instead, it only has a property. | ||
| // Therefore, we need to make sure that NSURLSessionConfiguration has this method to be able to |
There was a problem hiding this comment.
M: cant we swizzle a property?
There was a problem hiding this comment.
Not right now at the moment. We need to add the functionality or think of a different approach.
Codecov Report
@@ Coverage Diff @@
## master #1297 +/- ##
==========================================
+ Coverage 95.59% 95.61% +0.02%
==========================================
Files 149 149
Lines 5314 5317 +3
==========================================
+ Hits 5080 5084 +4
+ Misses 234 233 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
iOS 13 doesn't have a method for HTTPAdditionalHeaders. Instead, it only
has a property. Therefore, the swizzling crashes on iOS 13. This is fixed now
by checking if NSURLSessionConfiguration has a method HTTPAdditionalHeaders.
The downside is that we don't add a trace header on iOS 13 anymore. This
is better than crashing though.
I will add a test matrix to run the tests on older iOS versions soon.
💡 Motivation and Context
Fixes GH-1296
💚 How did you test it?
Running the tests on an iOS 13 simulator.
📝 Checklist
🔮 Next steps