Skip to content

ref: Prefix TracesSampler with Sentry #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2021
Merged

ref: Prefix TracesSampler with Sentry #1091

merged 1 commit into from
Apr 29, 2021
+14 −14

Conversation

philipphofmann
Copy link
Member

📜 Description

Rename TracesSampler to SentryTracesSampler to avoid namespace
clashes.

#skip-changelog

💡 Motivation and Context

We want to avoid namespace clashes.

💚 How did you test it?

CI.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the CHANGELOG if needed
  • I updated the docs if needed
  • Review from the native team if needed
  • No breaking changes

🔮 Next steps

Sorry, something went wrong.

@philipphofmann
ref: Prefix TracesSampler with Sentry

Verified

This commit was signed with the committer’s verified signature. The key has expired.
philipphofmann Philipp Hofmann
GPG key ID: 504CDC186493CD26
Expired
Verified
Learn about vigilant mode
95a0651 
Rename TracesSampler to SentryTracesSampler to avoid namespace
clashes.
@philipphofmann philipphofmann requested review from brustolin and a team April 28, 2021 10:05
bruno-garcia
bruno-garcia approved these changes Apr 29, 2021
View reviewed changes
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one. Lets ship this as 7.0.1 asap?

@philipphofmann philipphofmann merged commit ed86132 into master Apr 29, 2021
@philipphofmann philipphofmann deleted the ref/rename-traces-sampler branch April 29, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruno-garcia bruno-garcia

@brustolin brustolin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@philipphofmann @bruno-garcia