Skip to content

fix: Pass SentryTracer to span child. #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Conversation

brustolin
Copy link
Contributor

@brustolin brustolin commented Apr 1, 2021

📜 Description

Every new span child created need a reference to SentryTracer to be able to also create child.

💡 Motivation and Context

To fix a problem.

💚 How did you test it?

Unit test.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the CHANGELOG if needed
  • I updated the docs if needed
  • Review from the native team if needed
  • No breaking changes

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@codecov-io
Copy link

Codecov Report

Merging #1040 (ebffbaa) into master (ca91364) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1040   +/-   ##
=======================================
  Coverage   94.88%   94.88%           
=======================================
  Files          93       93           
  Lines        4083     4083           
=======================================
  Hits         3874     3874           
  Misses        209      209           
Impacted Files Coverage Δ
Sources/Sentry/SentryTracer.m 92.85% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca91364...ebffbaa. Read the comment docs.

@marandaneto
Copy link
Contributor

@brustolin please fill-up the Checklist accordingly

Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brustolin brustolin merged commit 6e2d29b into master Apr 6, 2021
@brustolin brustolin deleted the fix/passing-tracer branch April 6, 2021 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants