Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentry-cli 2.24.0 login with auth token causes errors #1888

Closed
PotatooSalad opened this issue Jan 5, 2024 · 2 comments · Fixed by #1889 or #1893
Closed

Sentry-cli 2.24.0 login with auth token causes errors #1888

PotatooSalad opened this issue Jan 5, 2024 · 2 comments · Fixed by #1889 or #1893
Assignees

Comments

@PotatooSalad
Copy link

I used sentry-cli version 2.24.0 in bash command line.

I was deploying new release to sentry, with the same settings as always and after sentry-cli login --auth-token [...]i got this error:thread 'main' panicked at 'Mismatch between definition and access of auth_token. Could not downcast to TypeId { t: 205527081075292425013923987422355844732 }, need to downcast to TypeId { t: 264673182028513726705440804281905241306 }
': C:\Users\runneradmin.cargo\registry\src\index.crates.io-6f17d22bba15001f\clap-4.1.6\src\parser\error.rs:30`

I tried with other tokens and I get the same message.

Yesterday everything was fine, issue started today after 2.24.0 release. I always use latest version to be up to date, but I guess I need to downgrade to 2.23.2 untill it's fixed.

@szokeasaurusrex
Copy link
Member

szokeasaurusrex commented Jan 5, 2024

Thank you for reporting this error; it appears related to a recent change (#1885) that was released in version 2.24.0. We will immediately investigate what is happening here.

@szokeasaurusrex
Copy link
Member

@PotatooSalad We just released a new version (2.24.1) of the CLI, which reverts the change that causes the error. If you upgrade to version 2.24.1, everything should work again.

Thank you for bringing this error to our attention, and have a nice weekend!

szokeasaurusrex added a commit that referenced this issue Jan 8, 2024
… `--auth-token` (#1893)

This PR fixes the bug in #1885 that led us to revert that commit. The bug, reported in #1888, caused the CLI to panic when the sentry-cli login command was called with the --auth-token argument.

We determined that the CLI panicked because the auth_token was being downcast to a String instead of to an AuthToken type when being read from the matches within the login command. This PR corrects the login command, so that the auth_token is correctly obtained from the matches as an AuthToken. We also checked whether the auth_token argument was being read as a String anywhere else in the code, and found that the login command was the only place the argument was being read as a String. Therefore, we would expect this PR to fix this class of bug completely.

Fixes GH-1859
Fixes GH-1888
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment