fix(rn): Remove hermesc envs if hermes is disabled #1754
Merged
+20
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If hermesc path is in envs react native tooling assumes hermes is enabled.
15 tasks
loewenheim
requested changes
Sep 25, 2023
src/commands/react_native/xcode.rs
Outdated
| @@ -263,16 +271,24 @@ pub fn execute(matches: &ArgMatches) -> Result<()> { | |||
| // With that we we then have all the information we need to invoke the | |||
| // upload process. | |||
| } else { | |||
| let rv = process::Command::new(&script) | |||
| let mut command= process::Command::new(&script); | |||
There was a problem hiding this comment.
Please run cargo fmt on the project as well.
There was a problem hiding this comment.
I did, but no changes emitted.
I fixed one extra empty line manually.
There was a problem hiding this comment.
Hm, that's odd. It doesn't do anything for me either, but my editor formats this correctly. Do you mind if I push my formatting changes?
There was a problem hiding this comment.
I don't mind. Go ahead.
loewenheim
approved these changes
Sep 25, 2023
loewenheim
approved these changes
Sep 25, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If hermesc path is in envs and exists react native tooling assumes hermes is enabled.
Sentry cli puts itself on the path therefore react native tooling always assumes hermes is enabled.
Todo: