Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rn): Upload root bundle source map for ram bundles #1743

Merged
merged 3 commits into from Sep 15, 2023

Conversation

krystofwoldrich
Copy link
Member

rust-sourcemap package only parses modules but doesn't include the root bundle file therefore also doesn't include it's source map.

src/utils/sourcemaps.rs Outdated Show resolved Hide resolved
src/utils/sourcemaps.rs Outdated Show resolved Hide resolved
@krystofwoldrich
Copy link
Member Author

@loewenheim Thank you for the suggestion, this is much cleaner.

Copy link
Contributor

@loewenheim loewenheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now

@loewenheim loewenheim merged commit a9903e7 into master Sep 15, 2023
16 checks passed
@loewenheim loewenheim deleted the kw-fix-missing-bundle-map-ram-bundles branch September 15, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support preloaded modules in file RAM bundles
2 participants