Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for SENTRY_RELEASE in bash-hook #1720

Merged
merged 4 commits into from Aug 28, 2023
Merged

Add support for SENTRY_RELEASE in bash-hook #1720

merged 4 commits into from Aug 28, 2023

Conversation

boozec
Copy link
Contributor

@boozec boozec commented Aug 27, 2023 •
edited

This PR adds support for SENTRY_RELEASE variable in the bash-hook command.
It adds --release argument in the command but the environment variable is
still available, so it checks the value from env first.

Resolves #1674

@boozec
Copy link
Contributor Author

boozec commented Aug 27, 2023

Clippy lint fails for some old sources, should I fix them anyway?

PS: on local instance it does not fail :\

@kamilogorek
Copy link
Contributor

kamilogorek commented Aug 28, 2023 •
edited

It fails because 4 days ago, Rust 1.72.0 was released, and as always, Clippy came with new defaults 😄

$ rustup update

:)

@boozec
Copy link
Contributor Author

boozec commented Aug 28, 2023

Ops, I missed the update to 1.72.0, thank you :)

@boozec boozec marked this pull request as ready for review August 28, 2023 08:18
kamilogorek
kamilogorek suggested changes Aug 28, 2023
View reviewed changes
src/commands/bash_hook.rs Outdated Show resolved Hide resolved
src/commands/bash_hook.rs Outdated Show resolved Hide resolved
src/commands/bash_hook.rs Outdated Show resolved Hide resolved
src/bashsupport.sh Outdated Show resolved Hide resolved
kamilogorek
kamilogorek suggested changes Aug 28, 2023
View reviewed changes
src/commands/bash_hook.rs Outdated Show resolved Hide resolved
tests/integration/_cases/bash_hook/bash_hook-help.trycmd Outdated Show resolved Hide resolved
@boozec
Copy link
Contributor Author

boozec commented Aug 28, 2023

Thank you for all the simplification tips :)

@kamilogorek kamilogorek enabled auto-merge (squash) August 28, 2023 10:29
kamilogorek
kamilogorek approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@kamilogorek kamilogorek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And thanks for the PR! :)

@kamilogorek kamilogorek merged commit 4e55418 into getsentry:master Aug 28, 2023
16 checks passed
@boozec boozec deleted the add-sentry-release-on-bash-hook branch September 1, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilogorek kamilogorek kamilogorek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support SENTRY_RELEASE in bash-hook
2 participants
@boozec @kamilogorek