fix: Correctly detect local binary when installing via npm #1695
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the nasty issue when using
npm
to install cli with locally existing binary.which
iterates over all possible binaries available in the PATH, and by default it reports the first occurrence.This is however problematic when using
npm
since I believe v8, as they started to include allnode_modules/.bin
in thePATH
when executing npm script, makingnpm run install
detect thebin/sentry-cli
file that we have, which is just a JS proxy to the actual binary.It works fine when running install script directly in node or using
yarn
, as they don't modify the PATH.We want the last possible match, eg.