Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sourcemap rewriting removes DebugIds #1685

Closed
2 tasks done
loewenheim opened this issue Jul 18, 2023 · 3 comments
Closed
2 tasks done

Sourcemap rewriting removes DebugIds #1685

loewenheim opened this issue Jul 18, 2023 · 3 comments
Assignees

Comments

@loewenheim
Copy link
Contributor

loewenheim commented Jul 18, 2023

Sourcemap rewriting parses the sourcemap into a Sourcemap structure, modifies it, and serializes it. Since the structure doesn't know about debug ids, those get lost in the parsing. The solution is to add debug id handling to rust-sourcemap.

Tasks

  1. loewenheim
  2. loewenheim
@kasszz
Copy link

kasszz commented Jul 23, 2023

Hey Loewenheim, I'm currently facing an issue that kinda let me to this problem aswel, maybe you can verify it with me.

I get errors in Sentry and I have the artifact uploaded correctly. But in the Issue it states that there is no Sourcemap. But when I manually download the .js and .js.map from the artifacts that the Issue is about and run it through the "Verify your source maps work locally" steps. I get the correct place.

But then I saw something about sentryDebugIds in this Troubleshooting guide But in the code it's not assigned to anything:
image

Long question short, is that what this github issue is about?

@kamilogorek
Copy link
Contributor

Long question short, is that what this github issue is about?

It's about cli removing the //# debugId=<uuid> pragma from the end of the file.

@loewenheim
Copy link
Contributor Author

Fixed as of sentry-cli 2.20.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants