Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(inject): Add semicolon at the end of inject snippet #1643

Merged
merged 1 commit into from
Jun 15, 2023
Merged

fix(inject): Add semicolon at the end of inject snippet #1643

merged 1 commit into from
Jun 15, 2023

Conversation

kamilogorek
Copy link
Contributor

Add a semicolon at the end of the injected snippet to prevent ASI issues.

Fixes #1642

@kamilogorek kamilogorek enabled auto-merge (squash) June 15, 2023 07:48
@kamilogorek kamilogorek merged commit aedad77 into master Jun 15, 2023
16 checks passed
@kamilogorek kamilogorek deleted the inject-asi-prevention branch June 15, 2023 07:50
@x1i4b1x2
Copy link

Thank you! Please make a release

@kamilogorek
Copy link
Contributor Author

It's already pending :) getsentry/publish#2363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lforst lforst lforst approved these changes

@loewenheim loewenheim Awaiting requested review from loewenheim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

After injection for sourcemaps: Uncaught TypeError: (intermediate value)(...) is not a function
3 participants
@kamilogorek @x1i4b1x2 @lforst